RelativeSource Binding Bug Fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lying on ancestor BindingContext or ancestry changes; (2) fix incorrect interpretation of AncestorLevel; (3) much more robust unit tests for RelativeSource ancestor-type binding
legistek
added a commit
that referenced
this pull request
Nov 17, 2019
(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes; (2) fix incorrect interpretation of AncestorLevel; (3) much more robust unit tests for RelativeSource ancestor-type binding (#4)
legistek
added a commit
that referenced
this pull request
Nov 18, 2019
(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes; (2) fix incorrect interpretation of AncestorLevel; (3) much more robust unit tests for RelativeSource ancestor-type binding (#4)
legistek
added a commit
that referenced
this pull request
Nov 26, 2019
* RelativeSource Binding Bug FIxes (1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes; (2) fix incorrect interpretation of AncestorLevel; (3) much more robust unit tests for RelativeSource ancestor-type binding (#4) * Update Xamarin.Forms.Core.UnitTests/RelativeSourceBindingTests.cs Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com> Fixes xamarin#8450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes;
(2) fix incorrect interpretation of AncestorLevel; (3) much more robust unit tests for RelativeSource ancestor-type binding