Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Shell,Android] BackButtonBehavior enables FlyoutBehavior #5219

Closed
davidortinau opened this issue Feb 12, 2019 · 0 comments
Closed

[Shell,Android] BackButtonBehavior enables FlyoutBehavior #5219

davidortinau opened this issue Feb 12, 2019 · 0 comments
Assignees
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/3 🕒 3 inactive Issue is older than 6 months and needs to be retested p/Android t/bug 🐛
Milestone

Comments

@davidortinau
Copy link
Contributor

davidortinau commented Feb 12, 2019

Description

When the FlyoutBehavior="Disabled" and then I add a BackButtonBehavior on a ContentPage, the flyout becomes active on Android.

Android: https://www.screencast.com/t/xqjM4PeTrEH

iOS: https://www.screencast.com/t/VpYNt6aRJsj3

Steps to Reproduce

<?xml version="1.0" encoding="UTF-8"?>
<Shell xmlns="http://xamarin.com/schemas/2014/forms" 
       xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" 
       xmlns:local="clr-namespace:VisualChallenge"
       RouteHost="companyname.com"
       RouteScheme="app"
       Route="VisualChallenge"
       FlyoutBehavior="Disabled"
       Title="VisualChallenge"
       x:Class="VisualChallenge.AppShell"
       Visual="Material"
       >
<?xml version="1.0" encoding="utf-8" ?>
<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:sys="clr-namespace:System;assembly=mscorlib"
             x:Class="VisualChallenge.VisualChallengePage"
             Shell.NavBarIsVisible="true"
             Title="Edit Request"
             >
    
    <ContentPage.ToolbarItems>
        <ToolbarItem Text="Save"/>
    </ContentPage.ToolbarItems>
    
    <Shell.BackButtonBehavior>
        <BackButtonBehavior TextOverride="Undo" IconOverride="{OnPlatform Android=blanky}"></BackButtonBehavior>
    </Shell.BackButtonBehavior>

Expected Behavior

Flyout doesn't become active.

Basic Information

@samhouts samhouts added the e/3 🕒 3 label Mar 2, 2019
@davidortinau davidortinau added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Mar 14, 2019
@PureWeen PureWeen added this to the 4.0.0 milestone Mar 22, 2019
@rmarinho rmarinho self-assigned this Mar 26, 2019
@rmarinho rmarinho mentioned this issue Mar 26, 2019
3 tasks
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Mar 27, 2019
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this issue Jun 15, 2019
…n#4767 fixes xamarin#4845 fixes xamarin#5219

* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [iOS,Shell] Fix issue when disposing ToolbarItems  of old page

* [Controls] Add demo repo for xamarin#5466

* [Shell,Core] Fix navigating to a registered route

* [Shell,Core] Add better exception messages for wrong or non existing content fixes xamarin#5081

* [Core,Shell,iOS,Android] Add FlyoutIcon property

* [Controls] Make shell sample work on Android

* [Controls,Android] Add ImageSource support to FlyoutIcon

* [Android]Allow to set text on the back button

* [Android] Create default text back button

* [Controls] Add example to push with back button behavior

* [Android] Fix back button tint color

* [Android] Cleanup and refactor UpdateDrawerArrow

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* [iOS,Shell] Fix go back (Pop) when proving BackButtonBehavior

* [iOS] Check the ParentViewController since we were push to it

* [Android,iOS,Shell] Remove extra code implement feedback

* removed old code

* minor cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/3 🕒 3 inactive Issue is older than 6 months and needs to be retested p/Android t/bug 🐛
Projects
None yet
Development

No branches or pull requests

4 participants