Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Shell] BackButtonBehavior is used to override the icon #4767

Closed
davidortinau opened this issue Dec 17, 2018 · 0 comments
Closed

[Shell] BackButtonBehavior is used to override the icon #4767

davidortinau opened this issue Dec 17, 2018 · 0 comments
Assignees
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/3 🕒 3 inactive Issue is older than 6 months and needs to be retested t/bug 🐛 t/enhancement ➕
Milestone

Comments

@davidortinau
Copy link
Contributor

davidortinau commented Dec 17, 2018

Description

This is done to override the back button.

var bbb = new BackButtonBehavior()
            {
                IconOverride = ImageSource.FromFile("close")
            };

            Shell.SetBackButtonBehavior(this, bbb);

"Behavior" here seems odd to me. Doesn't seem like a behavior.

Also when I do this, it replaces the hamburger, but also doesn't open the menu.

Expected Behavior

I can set the icon on a property of the Shell, a Style, or on the ContentPage.

Actual Behavior

I can only set in code like above via a behavior.

Basic Information

  • Version with issue: 4.0-pre1

Screenshots

https://www.screencast.com/t/TFrhknPNYhz3
Parent: #2415

@samhouts samhouts added this to the 4.0.0 milestone Jan 10, 2019
@davidortinau davidortinau added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Mar 14, 2019
@PureWeen PureWeen modified the milestone: 4.0.0 Mar 22, 2019
@samhouts samhouts added the e/3 🕒 3 label Mar 25, 2019
@rmarinho rmarinho self-assigned this Mar 26, 2019
@rmarinho rmarinho mentioned this issue Mar 26, 2019
3 tasks
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Mar 27, 2019
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this issue Jun 15, 2019
…n#4767 fixes xamarin#4845 fixes xamarin#5219

* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [iOS,Shell] Fix issue when disposing ToolbarItems  of old page

* [Controls] Add demo repo for xamarin#5466

* [Shell,Core] Fix navigating to a registered route

* [Shell,Core] Add better exception messages for wrong or non existing content fixes xamarin#5081

* [Core,Shell,iOS,Android] Add FlyoutIcon property

* [Controls] Make shell sample work on Android

* [Controls,Android] Add ImageSource support to FlyoutIcon

* [Android]Allow to set text on the back button

* [Android] Create default text back button

* [Controls] Add example to push with back button behavior

* [Android] Fix back button tint color

* [Android] Cleanup and refactor UpdateDrawerArrow

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* [iOS,Shell] Fix go back (Pop) when proving BackButtonBehavior

* [iOS] Check the ParentViewController since we were push to it

* [Android,iOS,Shell] Remove extra code implement feedback

* removed old code

* minor cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/3 🕒 3 inactive Issue is older than 6 months and needs to be retested t/bug 🐛 t/enhancement ➕
Projects
None yet
Development

No branches or pull requests

5 participants