-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rails seo #3319
Feature/rails seo #3319
Conversation
…ountry_controller
…ature Feature/rails seo country feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested. Other than that it looks good!
@desc = 'Data about forest change, tenure, forest related employment and land use' | ||
def show | ||
@title = @country["name"] | ||
@widget = params[:widget] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are not using a variable on the view you don't need to make it a instance variable @variable
you can use just variable
. Or in this case you can just use params[:widget]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok will remove! Thanks for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed :)
Overview
The country pages (and the whole app) needed a little SEO love. So we gave it. We are giving people. We give. To give is to gave.
For this feature we have updated the SEO capabilities of the country page to include:
CountryName | GFW (ish)
and if you share a widget the social card readsWidget Names in CountryName | GFW
. Pretty fancy eh?!Demo
Try sharing stuff with twitter.

Notes
We still need to get this working with dynamic widget images. To plan is to use
dom-to-image
to allow use to snap shot the image and store it in an amazon bucket, where we will store it for 30 days or so.Testing
Going to put on staging and get posting.