Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rails seo country feature #3318

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Feature/rails seo country feature #3318

merged 2 commits into from
Feb 21, 2018

Conversation

simaob
Copy link
Contributor

@simaob simaob commented Feb 21, 2018

Overview

This PR abstracts the methods used in the countries_controller to fetch country information from the GFW API, into a Country class. It then uses those same methods in the country_controller. As a bonus feature it refactors the country_controller to use the right action name for what is doing: show instead of index.

Testing

  • It all should work the same with the title of the page being the country name instead of the country iso.

@simaob simaob requested a review from edbrett February 21, 2018 18:31
edbrett
edbrett approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎏

@edbrett edbrett merged commit 832bacf into feature/rails-seo Feb 21, 2018
@edbrett edbrett deleted the feature/rails-seo-country-feature branch February 21, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbrett edbrett edbrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simaob @edbrett