Fix C++ ShuffleboardComponent template type #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `WithWidget(WidgetType&)`not being properly capitalized Add tests for ShuffleboardWidget
SamCarlberg
force-pushed
the
fix/shuffleboard-cpp
branch
from
dd17c48 to
0739107
Compare
wpiformat not updated for 2019 yet
|
@calcmogul Can you check out the watchdog changes I just pushed? I want to make sure I did them right. |
Just wanted to remove the inheritance
|
I updated this to use constexpr and not require C++ 17. Still left in the Binary Function removal, as that was deprecated even in 11. |
Overloads were added for the other cases
PeterJohnson
approved these changes
Feb 15, 2019
amrelk
pushed a commit
to amrelk/allwpilib
that referenced
this pull request
Apr 4, 2019
* Fix C++ ShuffleboardComponent template type * Fix `WithWidget(WidgetType&)`not being properly capitalized * Fix data members across dll boundaries by using enum for built in types
pjbuterbaugh
pushed a commit
to pjbuterbaugh/allwpilib
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
WithWidget(WidgetType&)not being properly capitalizedAdd tests for ShuffleboardWidget