Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight words #4175

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Highlight words #4175

merged 3 commits into from
Dec 9, 2021

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Oct 28, 2021 •
edited
Loading

Fixes #1212

This PR adds the functionality to be able to customize colors for selected words. For now, users will only be able to change the text color, the functionality to customize the background color will not be supported on mobile for now.

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the [Type] Enhancement Improves a current area of the editor label Oct 28, 2021
This was referenced Oct 28, 2021
Merged
Closed
Closed
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 28, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux marked this pull request as ready for review November 3, 2021 15:43
@geriux geriux added this to the 1.66.0 (18.7) milestone Nov 4, 2021
@fluiddot
Copy link
Contributor

Hey @geriux !
We will cut the 1.66.0 release on 2021-11-11. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.66.0. Thanks!

@geriux geriux modified the milestones: 1.66.0 (18.7), 1.67.0 (18.8) Nov 11, 2021
@SiobhyB
Copy link
Contributor

SiobhyB commented Nov 24, 2021

👋 @geriux, we plan to cut the 1.67.0 release around 10:00 UTC tomorrow, on Thursday 25th November. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.67.0.

As a reminder, changes in the next (1.68.0) release won't be shipped to users until the 10th January.

Thanks!

@SiobhyB SiobhyB modified the milestones: 1.67.0 (18.8), 1.68.0 (18.9) Nov 26, 2021
@geriux geriux requested a review from antonis November 30, 2021 16:23
antonis
antonis approved these changes Dec 2, 2021
View reviewed changes
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#36028 (review)

@guarani
Copy link
Contributor

guarani commented Dec 7, 2021

👋 Hi @geriux. We will cut the 1.68.0 release on Dec 9th. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.68.0. 🙇

@geriux geriux force-pushed the feature/highlight-color branch from 1898464 to 5b42f7a Compare December 9, 2021 12:47
@geriux geriux merged commit 6020e03 into develop Dec 9, 2021
@geriux geriux deleted the feature/highlight-color branch December 9, 2021 13:16
@geriux geriux mentioned this pull request Dec 9, 2021
Merged
2 tasks
@guarani guarani mentioned this pull request Dec 9, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

Assignees
No one assigned
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.68.0 (18.9)
Development

Successfully merging this pull request may close these issues.

Allow Selecting Text Color in Blocks with Text
5 participants
@geriux @fluiddot @SiobhyB @guarani @antonis