-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mark inline formatting #943
Conversation
Hey there @hypest @mchowning 👋 I'm having an issue with this feature and I saw you have worked on this project before, I was wondering if any of you might have some insight 😄 Currently, if you have a word typed in, and an empty Screenrecorder-2021-11-17-10-47-01-827.mp4Have you seen this before? I updated the demo app content to show the current issue. Any guidance would be appreciated. Thanks! |
👋 @geriux , thanks for the ping! Haven't really dug deeply into this yet, but thought of sharing this in case it helps in the meantime: I wonder if there's some mixup with inline and block level elements handling here that leads to that separate to appear. For example, I see that it's the |
aztec/src/main/kotlin/org/wordpress/aztec/formatting/InlineFormatter.kt
Outdated
Show resolved
Hide resolved
aztec/src/main/kotlin/org/wordpress/aztec/formatting/InlineFormatter.kt
Outdated
Show resolved
Hide resolved
aztec/src/main/kotlin/org/wordpress/aztec/formatting/InlineFormatter.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @geriux 👍
I tested with the Gutenberg PR and everything works as expected. The code also LGTM 🎉
I added a couple of comments that do not affect the code functionally :)
96a3deb
to
3823851
Compare
This PR is a follow-up of #939 to wrap up adding
Mark
formatting support.To test this feature, use the iOS build from this PR that uses this feature.
Fix
Adds Mark formatting capabilities.
Test
For test cases, you can check the description of this PR.
Review
@antonis
Make sure strings will be translated:
strings.xml
as a part of the integration PR.