Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Enable embed preview for a list of providers #3900

Merged
merged 10 commits into from
Sep 2, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Sep 1, 2021

gutenberg PR: WordPress/gutenberg#34446

To test:
Follow testing instructions from gutenberg PR: WordPress/gutenberg#34446.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 1, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34446. Need to update Gutenberg reference after the mentioned PR is merged to trunk.

@mkevins
Copy link
Contributor

mkevins commented Sep 2, 2021

Hi @fluiddot 👋 😄 . We will be cutting the 1.61.0 release either today, or tomorrow, depending on the resolution of another issue. Since this PR is already approved, I haven't bumped the milestone. I see that there is an unresolved lint issue on the related Gutenberg PR, so please let me know if you'd like to get this into the 1.61.0 release, or if not, I can bump the milestone. Thanks!

@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 2, 2021

Hi @fluiddot 👋 😄 . We will be cutting the 1.61.0 release either today, or tomorrow, depending on the resolution of another issue. Since this PR is already approved, I haven't bumped the milestone. I see that there is an unresolved lint issue on the related Gutenberg PR, so please let me know if you'd like to get this into the 1.61.0 release, or if not, I can bump the milestone. Thanks!

Hey @mkevins 👋 , I'd like if possible to get this into 1.61.0. I've just seen that the lint issue that blocks this PR is already solved so I'll update the branch and merge it. I'll let you know when it's ready, thanks 🙇 !

@fluiddot fluiddot changed the title [Embed block] Enable embed preview by static list of providers [Embed block] Enable embed preview for a list of providers Sep 2, 2021
@fluiddot fluiddot merged commit 0dff914 into develop Sep 2, 2021
@fluiddot fluiddot deleted the embed-block-enable-preview-by-providers branch September 2, 2021 09:21
@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 2, 2021

The PR is finally merged so it will be included in 1.61.0.

cc @mkevins @antonis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants