Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Enable inline preview only for the top 5 most-used providers #3816

Closed
fluiddot opened this issue Aug 10, 2021 · 6 comments
Closed

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Aug 10, 2021

Related to #3278.

Description

  • Needs research: Determine by looking into data the top 8 most-used ones.
  • Add a static list of providers including the top 8 most-used and enable the inline preview for them. The rest of the providers will display the "preview coming soon" message.

Most-used providers (list based on #3816 (comment)):

  1. YouTube ✅ (enabled in [Embed block] Enable embed preview for a list of providers #3900)
  2. Twitter ✅ (enabled in [Embed block] Enable embed preview for a list of providers #3900)
  3. WordPress ✅ (enabled in [Embed block] Enable WordPress embed preview #3853)
  4. Instagram ✅ (enabled in [Embed block] Enable embed preview for Instagram and Vimeo providers #3918)
  5. Vimeo ✅ (enabled in [Embed block] Enable embed preview for Instagram and Vimeo providers #3918)
@hypest
Copy link
Contributor

hypest commented Aug 27, 2021

Needs research: Determine by looking into data the top 8 most-used ones.

Based on data from WPCOM usage, here's the top ones, in order of popularity, we shall look into enabling inline preview for: YouTube, Twitter, WordPress, Instagram, Vimeo.

And just to add more nuance, let's make sure we're able to individually enable inline preview for any of those, as soon as we're happy with each one's preview.

@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 1, 2021

Needs research: Determine by looking into data the top 8 most-used ones.

Based on data from WPCOM usage, here's the top ones, in order of popularity, we shall look into enabling inline preview for: YouTube, Twitter, WordPress, Instagram, Vimeo.

And just to add more nuance, let's make sure we're able to individually enable inline preview for any of those, as soon as we're happy with each one's preview.

Thanks @hypest for the usage insights ❤️ !

I'll open a PR to enable the inline preview by providers, this way we could focus on addressing potential issues for each provider and enable them one by one, once we're confident they're ready for usage.

@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 1, 2021

I'll open a PR to enable the inline preview by providers, this way we could focus on addressing potential issues for each provider and enable them one by one, once we're confident they're ready for usage.

Here is the PR that enables the inline previews by providers, for now, I only included YouTube and Twitter.

@fluiddot fluiddot self-assigned this Sep 1, 2021
@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 3, 2021

Heads up that the previews for WordPress embeds are now available (related PR) 🎊 .

@jd-alexander
Copy link
Contributor

jd-alexander commented Sep 6, 2021

I created a PR that enables Instagram and Vimeo providers #3918 I didn't notice any issues with the rendering of the embed preview.

@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 15, 2021

Previews for all top 5 most-used providers have been enabled 🎊 .

@fluiddot fluiddot changed the title [Embed block] Enable inline preview only for the top 8 most-used providers [Embed block] Enable inline preview only for the top 5 most-used providers Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants