-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Embed block] Enable inline preview only for the top 5 most-used providers #3816
Comments
Based on data from WPCOM usage, here's the top ones, in order of popularity, we shall look into enabling inline preview for: YouTube, Twitter, WordPress, Instagram, Vimeo. And just to add more nuance, let's make sure we're able to individually enable inline preview for any of those, as soon as we're happy with each one's preview. |
Thanks @hypest for the usage insights ❤️ ! I'll open a PR to enable the inline preview by providers, this way we could focus on addressing potential issues for each provider and enable them one by one, once we're confident they're ready for usage. |
Here is the PR that enables the inline previews by providers, for now, I only included YouTube and Twitter. |
Heads up that the previews for WordPress embeds are now available (related PR) 🎊 . |
I created a PR that enables Instagram and Vimeo providers #3918 I didn't notice any issues with the rendering of the embed preview. |
Previews for all top 5 most-used providers have been enabled 🎊 . |
Related to #3278.
Description
Most-used providers (list based on #3816 (comment)):
The text was updated successfully, but these errors were encountered: