Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make media-text respect stacking setting on native #1400

Merged
merged 6 commits into from
Oct 10, 2019
Merged

Conversation

koke
Copy link
Member

@koke koke commented Oct 2, 2019

See WordPress/gutenberg#17682

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@koke koke added the Blocks label Oct 2, 2019
@koke koke added this to the 1.15 milestone Oct 2, 2019
@koke koke requested a review from mkevins October 2, 2019 15:28
@pinarol
Copy link
Contributor

pinarol commented Oct 4, 2019

Created an issue for this to track on the board #1407

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I tested several scenarios described here: WordPress/gutenberg#17682 (comment). LGTM! 🎉

@koke koke merged commit a461fc8 into develop Oct 10, 2019
@koke koke deleted the media-text-stacking branch October 10, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants