-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make media-text respect stacking setting on native #17682
Conversation
Testing on WPiOS:
|
I tested this on a Pixel 3a with Android 10 (portrait and landscape), as well as in a local web install (normal mode, and emulating mobile, portrait + landscape via Chrome Devtools), and everything works as described. 🎉 Screenshots:
The issue described here: #17682 (comment) seems to have been resolved here: ace01c9 Very nice work @koke , and thanks @geriux for adding the null-check. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very nice seeing the dimension event listener working well on mobile in this PR! 😃
Nice work @koke 🎉
Description
After #14364, the Media & Text block is stacked by default on mobile. The native implementation was wrongly assuming that
mobile == native
and stacking even on larger screens. Besides, it would still set the width for each column to 50%, so it would look wrong.gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1400
How has this been tested?
Tested on WordPress for iOS and web.
Screenshots
Native:
Web:
Types of changes
Beyond the fix specific to Media & Text, this completes the native implementation of
@wordpress/viewport
.Checklist: