Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Table 4.1 and 4.2: new category for thermodynamical properties in discipline "land surface" and associated parameters #251

Closed
sebvi opened this issue May 2, 2024 · 10 comments
Assignees
Milestone

Comments

@sebvi
Copy link
Contributor

sebvi commented May 2, 2024

Initial request

ECMWF is proposing a new category under discipline 2 - Land surface to encode various thermodynamical properties (heat fluxes). This requires a new entry in Code table 4.1 for the new category and a new sub-table 4.2 discipline 2, category 7

Additional, ECMWF is requesting a new parameter in code table 4.2, discipline 0, category 4

Amendment details

ADD new Category in Code Table 4.1 discipline 2 Thermodynamic properties

Code Name
7 Thermodynamic properties

ADD new entries in Code table 4.2 discipline 2 category 7

Parameter number name Unit
0 Heat net flux (see Note) [W m-2]
1 Latent heat net flux [W m-2]
2 Sensible heat net flux [W m-2]

Note: Heat net flux is the sum of latent heat net flux and sensible heat net flux.

ADD new entry in Code table 4.2 discipline 0 category 4

Parameter number name Unit
62 Direct normal short-wave radiation flux, clear sky (see note) [W m-2]

Note: Normal flux is on a surface lifted to be normal to sun rays

ADD new entry in Code Table 4.2 discipline 0 category 19

Parameter number name Unit
51 Visibility through precipitation [m]

Add new entry in Code Table 4.2 discipline 3 category 1

Parameter number name Unit
24 Cosine of the solar zenith angle [Numeric]

ADD new entries to Code Table 4.2 discipline 0 category 2

Parameter number name Unit
68 Convective gust [m s-1]
69 Turbulent gust [m s-1]

Comments

No response

Requestor(s)

Sebastien Villaume (ECMWF)
Matthew Griffith (ECMWF)

Stakeholder(s)

ECMWF
EU - Destination Earth programme

Publication(s)

Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.1 (update)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 0, category 4 (update)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.2, discipline 2, category 7 (new subtable)

Expected impact of change

LOW

Collaborators

No response

References

No response

Validation

No response

@amilan17 amilan17 added this to the FT2024-2 milestone May 2, 2024
@sebvi sebvi self-assigned this May 14, 2024
@sebvi
Copy link
Contributor Author

sebvi commented Jun 5, 2024

I have just added parameters that were forgotten

@sebvi
Copy link
Contributor Author

sebvi commented Jun 24, 2024

branch created and updated

@amilan17
Copy link
Member

amilan17 commented Jul 2, 2024

https://github.com/wmo-im/CCT/wiki/Teleconference.2.July.2024 notes:
Sebastien introduced the proposal; there was discussion about the "Cosine of the SZA" parameter, but team agrees to proposal in general; @sebvi and @SibylleK check with colleagues on the requirements for cosine;

@amilan17
Copy link
Member

amilan17 commented Jul 8, 2024

@sebvi the note is missing - it is referenced in Code table 4.2 discipline 2 category 7, but I don't see a note in the proposal nor the branch

@SibylleK
Copy link
Contributor

Maybe note (1) "By convention, the flux sign is positive if downwards" of Code table 4.2 is meant here.

In any case, I received a corresponding note from my colleague, that it would be good to clarify, that this note is also valid for these surface fluxes.

Another comment is, to consider to define these new entries as ".. total flux", as in future you might be able to diffferentiate between e.g. "due to exaporation" and "due to sublimation".

@mjg41
Copy link

mjg41 commented Jul 18, 2024

Apologies the Note got lost somewhere along the way, it was intended to be:

Note: Heat net flux is the sum of latent heat net flux and sensible heat net flux

The new entry 62 in Code table 4.2 discipline 0 category 4 should also be linked to Note ID 69.

Many thanks.

@amilan17
Copy link
Member

amilan17 commented Aug 2, 2024

@sebvi @mjg41 Is this the correct note for entry 62?

Parameter number name Unit
62 Direct normal short-wave radiation flux, clear sky [W m-2]

69,Normal flux is on a surface lifted to be normal to sun rays.

amilan17 added a commit that referenced this issue Aug 2, 2024
@amilan17
Copy link
Member

amilan17 commented Aug 2, 2024

Another comment is, to consider to define these new entries as ".. total flux", as in future you might be able to diffferentiate between e.g. "due to exaporation" and "due to sublimation".

@SibylleK @sebvi does this need discussion? if so -- we cannot include this proposal in FT2024-2.

@sebvi
Copy link
Contributor Author

sebvi commented Aug 8, 2024

parameters in Code Tables 4.2..0.4 and 4.2.0.5 don't specify "total" when it is assumed total so I would not make these parameters different for consistency.

@amilan17
Copy link
Member

amilan17 commented Aug 9, 2024

it was determined through email that it's not necessary to revise this proposal further.

amilan17 added a commit that referenced this issue Aug 9, 2024
…in discipline land surface and associated parameters (#266)

* #251 adding entries in subtables of codec table 4.2

* fix rebase conflicts for xml,txt files

* change capitilization

* xml,txt files

* #251 add notes

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

add note number

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

change note number again

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>
@amilan17 amilan17 moved this to Ready for FT Approval Procedure in GRIB2 Amendments Aug 22, 2024
amilan17 added a commit that referenced this issue Nov 7, 2024
* xml,txt files

* 247 code table 49 add an entry to encode a probability based on a quantile distribution instead of based on a threshold (#265)

* fix rebase conflict xml,txt files

* fix rebase conflicts 247 adding entry in COde table 4.9 and associated note

* fix rebase conflicts xml,txt files

* xml,txt files

* #247 changing PDF acronym to probability distribution function

* xml,txt files

* remove odd char

* xml,txt files

* xml,txt files

* remove datestamp from XML gen

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* 253 new normal and tangential velocity.... (#270)

* xml,txt files

* xml,txt files

* issue #253 update branch

* xml,txt files

* Update GRIB2_CodeFlag_4_2_10_4_CodeTable_en.csv

53 and 54 for normal and tangential component of water velocity, as entry 52 is used in issue 244 for mixed layed depth.

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>

* 248 code table 4101 new entry in code table 4101 to extend the usage of templates 4105 4106 4107 and 4112 (#263)

* fix rebase conflict: 248 adding entry in Code Table 4.101 and associated note

* fix rebase of xml,txt files

* fix legacy conflict text

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 244 new new mixed layer depth parameter in code table 42 discipline 10 1 (#262)

* issue #244 in NEW branch

* xml,txt files

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 246 additional anomalies templates (#268)

* #246 adding template 4.128 to 4.136 and entries in code table 4.0

* rebase fix xml,txt files

* Update GRIB2_Template_4_129_ProductDefinitionTemplate_en.csv

Replace "to" with "-"

* xml,txt files

* Update GRIB2_Template_4_131_ProductDefinitionTemplate_en.csv

upper limit

* xml,txt files

* Update GRIB2_Template_4_134_ProductDefinitionTemplate_en.csv

"51-62" not as octetNo

* xml,txt files

* Update GRIB2_Template_4_136_ProductDefinitionTemplate_en.csv

upper limit and typo in line 47

* xml,txt files

* fix CSV

* xml,txt files

* Apply suggestions from code review

update see note references

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>

* 245 deprecate template 444 create rectified version as template 450 (#269)

* #245 deprecate template 4.44, create new corrected template 4.50 and update Code table 4.0 accordingly

* xml,txt files

* Update GRIB2_CodeFlag_4_0_CodeTable_en.csv

* xml,txt files

* Update GRIB2_Template_4_50_ProductDefinitionTemplate_en.csv

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 250 code table 42 and 4238 new sourcesink entries in code table 4238 and a new parameter in code table 42 discipline 0 category 20 (#274)

* #250 adding entries in code table 4.22.0.20 and 4.238

* xml,txt files

* #250 updating entries to only keep sink and source (removing loss and gain)

* xml,txt files

* xml,txt files

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 238 new precipitation type flag... (#267)

#238

* xml,txt files

* 271 remove date from xml script (#272)

* xml,txt files

* Update create_master_lists.py

Remove the generation of the 'generated' param to avoid complex merging process.

Now the xml header won't have the 'generated' param anymore

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>

* xml,txt files

* xml,txt files

* update branch for issue #238

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: antoineMerleEUM <antoine.merle@eumetsat.int>

* 249 code table 14 43 and 46 adding new entries to better describe type of forecasting (#261)

#249 
* fix rebase conflict: 249 adding entries in code table 1.4, 4.3 and 4.6 with associated notes

* fix rebase of xml,txt files

* #249, add notes, change sample to example

* xml,txt files

* editorial, changed 23 to 22 in CF4.3

* xml,txt files

* Update GRIB2_CodeFlag_4_6_CodeTable_en.csv

Co-authored-by: Marijana Crepulja <62389855+marijanacrepulja@users.noreply.github.com>

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Marijana Crepulja <62389855+marijanacrepulja@users.noreply.github.com>

* Update notes/CodeFlag_notes.csv

* 251 code table 41 and 42 new category for thermodynamical properties in discipline land surface and associated parameters (#266)

* #251 adding entries in subtables of codec table 4.2

* fix rebase conflicts for xml,txt files

* change capitilization

* xml,txt files

* #251 add notes

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

add note number

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

change note number again

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 249 new2 (#275)

* Code table 1.4, 4.3 and 4.6: Adding new entries to better describe type of forecasting #249

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>
Co-authored-by: antoineMerleEUM <antoine.merle@eumetsat.int>
Co-authored-by: Marijana Crepulja <62389855+marijanacrepulja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants