Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate template 4.44, create rectified version as template 4.50 #245

Closed
sebvi opened this issue May 1, 2024 · 8 comments
Closed

Deprecate template 4.44, create rectified version as template 4.50 #245

sebvi opened this issue May 1, 2024 · 8 comments
Assignees
Milestone

Comments

@sebvi
Copy link
Contributor

sebvi commented May 1, 2024

Initial request

The template 4.44, Analysis or forecast at a horizontal level or in a horizontal layer at a point in time for aerosol is marked as operational, however it is recommended not to use this template: "PDT 4.48 Analysis or forecast at a horizontal level or in a horizontal layer at a point in time for optical properties of aerosol should be used instead with the optical wavelength range set to missing".
The issue with template 4.44 is that the forecast time has only 2 octets instead of the usual 4 octets. This means that deterministic forecasts for aerosols use the template 4.48 which includes additionally keys for the optical wavelength (all set to missing to ignore them) while for probabilistic aerosol forecasts the aerosol-only template 4.45 can be used. This leads to a discrepancy in the layout of the same data coming from deterministic and probabilistic model runs.

We propose to deprecate the template 4.44 and properly create a new template 4.50 (instead of 4.48 with keys set to missing) with the forecast time having 4 octets as it is the case in the corresponding probabilistic aerosol template 4.45.

Amendment details

DEPRECATE template 4.44 and CREATE a corrected version as template 4.50.

ADD to code table 4.0 - Product definition template number

Code Description
50 Analysis or forecast at a horizontal level or in a horizontal layer at a point in time for aerosol

CREATE Template 4.50 - Analysis or forecast at a horizontal level or in a horizontal layer at a point in time for aerosol

Octet Number of octets Description
10 1 Parameter Category (see code table 4.1)
11 1 Parameter Number (see code table 4.2)
12-13 2 Aerosol Type (see common code table C-14)
14 1 Type of Size Interval (see code table 4.91)
15 1 Scale Factor of First Size
16-19 2 Scaled Value of First Size
20 1 Scale Factor of Second Size
21-24 2 Scaled Value of Second Size
25 1 Type of Generating Process (see code table 4.3)
26 1 Background Process
27 1 Generating Process Identifier
28-29 2 Hours After Data Cut-off
30 1 Minutes After Data Cut-off
31 1 Indicator of Unit of Time Range (see code table 4.4)
32-35 4 Forecast Time
36 1 Type of First Fixed Surface (see code table 4.5)
37 1 Scale Factor of First Fixed Surface
38-41 4 Scaled Value of First Fixed Surface
42 1 Type of Second Fixed Surface (see code table 4.5)
43 1 Scale Factor of Second Fixed Surface
44-47 4 Scaled Value of Second Fixed Surface

Comments

No response

Requestor(s)

ECMWF

Stakeholder(s)

ECMWF

Publication(s)

Manual on Codes (WMO-No. 306), Volume I.2, GRIB code table 4.0 (update)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB Template 4.44 (deprecate)
Manual on Codes (WMO-No. 306), Volume I.2, GRIB Template 4.48 (create)

Expected impact of change

MEDIUM

Collaborators

Sebastien Villaume (ECMWF)
Robert Osinski (ECMWF)

References

No response

Validation

No response

@sebvi sebvi self-assigned this May 1, 2024
@amilan17 amilan17 added this to the FT2024-2 milestone May 2, 2024
@amilan17
Copy link
Member

amilan17 commented May 2, 2024

2024-05-02 notes:
Sebastien presented the proposal; Sibylle proposed a different solution with entries set to missing instead (@SibylleK can you add details in comment below?); Sebastien it is preferred to have a new template instead of using an existing template

@amilan17
Copy link
Member

amilan17 commented Jun 5, 2024

https://github.com/wmo-im/CCT/wiki/Teleconference.2024.June.4and5 notes:
Sebastien summarized the two options for moving forward (new template or set values to missing in existing template);
DECISION: move forward with new template;

sebvi added a commit that referenced this issue Jun 24, 2024
@sebvi
Copy link
Contributor Author

sebvi commented Jun 24, 2024

branch created and updated according to DECISION

@amilan17
Copy link
Member

amilan17 pushed a commit that referenced this issue Jun 26, 2024
@sebvi
Copy link
Contributor Author

sebvi commented Jul 2, 2024

You can find a branch of ecCodes implementing template 4.50 here: feature/ft2024-2_245

a sample is attached:
50.grib2.zip

@amilan17
Copy link
Member

amilan17 commented Jul 2, 2024

https://github.com/wmo-im/CCT/wiki/Teleconference.2.July.2024 notes:
@SibylleK will review the samples

@amilan17
Copy link
Member

https://github.com/wmo-im/CCT/wiki/Teleconference.2.July.2024 notes: @SibylleK will review the samples

@SibylleK have you had a chance to validate the samples yet?

@SibylleK
Copy link
Contributor

@amilan17 the template is validated.

I was able to decode the sample grib with a DWD GRIB reading software using the definitions of the branch.
The values in section 4 are the same as in eccodes grib_dump.

amilan17 added a commit that referenced this issue Jul 12, 2024
…269)

* #245 deprecate template 4.44, create new corrected template 4.50 and update Code table 4.0 accordingly

* xml,txt files

* Update GRIB2_CodeFlag_4_0_CodeTable_en.csv

* xml,txt files

* Update GRIB2_Template_4_50_ProductDefinitionTemplate_en.csv

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>
@amilan17 amilan17 moved this to Ready for FT Approval Procedure in GRIB2 Amendments Aug 22, 2024
amilan17 added a commit that referenced this issue Nov 7, 2024
* xml,txt files

* 247 code table 49 add an entry to encode a probability based on a quantile distribution instead of based on a threshold (#265)

* fix rebase conflict xml,txt files

* fix rebase conflicts 247 adding entry in COde table 4.9 and associated note

* fix rebase conflicts xml,txt files

* xml,txt files

* #247 changing PDF acronym to probability distribution function

* xml,txt files

* remove odd char

* xml,txt files

* xml,txt files

* remove datestamp from XML gen

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>

* 253 new normal and tangential velocity.... (#270)

* xml,txt files

* xml,txt files

* issue #253 update branch

* xml,txt files

* Update GRIB2_CodeFlag_4_2_10_4_CodeTable_en.csv

53 and 54 for normal and tangential component of water velocity, as entry 52 is used in issue 244 for mixed layed depth.

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>

* 248 code table 4101 new entry in code table 4101 to extend the usage of templates 4105 4106 4107 and 4112 (#263)

* fix rebase conflict: 248 adding entry in Code Table 4.101 and associated note

* fix rebase of xml,txt files

* fix legacy conflict text

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 244 new new mixed layer depth parameter in code table 42 discipline 10 1 (#262)

* issue #244 in NEW branch

* xml,txt files

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 246 additional anomalies templates (#268)

* #246 adding template 4.128 to 4.136 and entries in code table 4.0

* rebase fix xml,txt files

* Update GRIB2_Template_4_129_ProductDefinitionTemplate_en.csv

Replace "to" with "-"

* xml,txt files

* Update GRIB2_Template_4_131_ProductDefinitionTemplate_en.csv

upper limit

* xml,txt files

* Update GRIB2_Template_4_134_ProductDefinitionTemplate_en.csv

"51-62" not as octetNo

* xml,txt files

* Update GRIB2_Template_4_136_ProductDefinitionTemplate_en.csv

upper limit and typo in line 47

* xml,txt files

* fix CSV

* xml,txt files

* Apply suggestions from code review

update see note references

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>

* 245 deprecate template 444 create rectified version as template 450 (#269)

* #245 deprecate template 4.44, create new corrected template 4.50 and update Code table 4.0 accordingly

* xml,txt files

* Update GRIB2_CodeFlag_4_0_CodeTable_en.csv

* xml,txt files

* Update GRIB2_Template_4_50_ProductDefinitionTemplate_en.csv

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 250 code table 42 and 4238 new sourcesink entries in code table 4238 and a new parameter in code table 42 discipline 0 category 20 (#274)

* #250 adding entries in code table 4.22.0.20 and 4.238

* xml,txt files

* #250 updating entries to only keep sink and source (removing loss and gain)

* xml,txt files

* xml,txt files

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 238 new precipitation type flag... (#267)

#238

* xml,txt files

* 271 remove date from xml script (#272)

* xml,txt files

* Update create_master_lists.py

Remove the generation of the 'generated' param to avoid complex merging process.

Now the xml header won't have the 'generated' param anymore

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>

* xml,txt files

* xml,txt files

* update branch for issue #238

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: antoineMerleEUM <antoine.merle@eumetsat.int>

* 249 code table 14 43 and 46 adding new entries to better describe type of forecasting (#261)

#249 
* fix rebase conflict: 249 adding entries in code table 1.4, 4.3 and 4.6 with associated notes

* fix rebase of xml,txt files

* #249, add notes, change sample to example

* xml,txt files

* editorial, changed 23 to 22 in CF4.3

* xml,txt files

* Update GRIB2_CodeFlag_4_6_CodeTable_en.csv

Co-authored-by: Marijana Crepulja <62389855+marijanacrepulja@users.noreply.github.com>

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Marijana Crepulja <62389855+marijanacrepulja@users.noreply.github.com>

* Update notes/CodeFlag_notes.csv

* 251 code table 41 and 42 new category for thermodynamical properties in discipline land surface and associated parameters (#266)

* #251 adding entries in subtables of codec table 4.2

* fix rebase conflicts for xml,txt files

* change capitilization

* xml,txt files

* #251 add notes

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

add note number

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

change note number again

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>

* 249 new2 (#275)

* Code table 1.4, 4.3 and 4.6: Adding new entries to better describe type of forecasting #249

* xml,txt files

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>

---------

Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Sebastien Villaume <sebastien.villaume@ecmwf.int>
Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>
Co-authored-by: antoineMerleEUM <antoine.merle@eumetsat.int>
Co-authored-by: Marijana Crepulja <62389855+marijanacrepulja@users.noreply.github.com>
@amilan17 amilan17 closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants