feat(transport): Add shouldThrow as an option to fallback transport #3414
+81
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `shouldThrow` option to the fallback transport, to customize which errors trigger a fallback vs a throw.
🦋 Changeset detectedLatest commit: c48a1d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@spalladino is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
jxom
reviewed
Mar 6, 2025
src/clients/transports/fallback.ts
Outdated
| @@ -203,7 +206,7 @@ export function fallback<const transports extends readonly Transport[]>( | |||
| }) as FallbackTransport<transports> | |||
| } | |||
|
|
|||
| function shouldThrow(error: Error) { | |||
| function defaultShouldThrow(error: Error) { | |||
There was a problem hiding this comment.
Perhaps we export this, so others can use it in their custom shouldThrow function.
|
Looks good. Needs some tests. |
|
@jxom thanks for reviewing! Added a test and changeset entry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
shouldThrowoption to the fallback transport, to customize which errors trigger a fallback vs a throw. We are using this so a contract error (eg a failedrequirein contract code) does not trigger the fallback and fails immediately.Happy to add some tests if this contribution makes sense.