fix: custom fallback transport #12470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Looks good! Just threw in a few comments. Also sent a quick PR to viem to see if they can add shouldThrow as a config.
| @@ -55,7 +55,7 @@ import { Attributes, type TelemetryClient, type Traceable, type Tracer, trackSpa | |||
|
|
|||
| import { EventEmitter } from 'events'; | |||
| import groupBy from 'lodash.groupby'; | |||
| import { type GetContractReturnType, createPublicClient, fallback, getContract, http } from 'viem'; | |||
| import { type GetContractReturnType, createPublicClient, getContract, http } from 'viem'; | |||
There was a problem hiding this comment.
Let's add a rule to eslint so we don't accidentally import viem's fallback instead of our own: https://eslint.org/docs/latest/rules/no-restricted-imports#importnames
| import type { ExtendedViemWalletClient } from '../types.js'; | ||
| import { startAnvil } from './start_anvil.js'; | ||
|
|
||
| describe('fallback_transport', () => { |
There was a problem hiding this comment.
Let's add a test for the transport not falling back on a contract error (main reason why you implemented this as far as I understand!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallbacktransport by viem works by trying the first node it was given, and if it receives an error, it moves on to the next, unlessshouldThrowreturnstrue.shouldThrowhowever was not triggered on contract errors so with checks likecanProposeAt, it would try secondary nodes, even though the 1st node returned the correct result (a contract error)This implementation of
fallbacktransport throws immediately when we receive any contract error