refactor: add renderData utility to template package #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renderData is similar to renderTemplate but returns maps of data which is used by most of builder utilities and component generator. Here migrated to it css and component generator and used it to generate data sources where possible.
|
I was confused about the name at first because data is output, render takes stilll jsx, maybe jsxToData would be a better name? |
kof
approved these changes
Jan 23, 2025
|
render is the key here IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renderData is similar to renderTemplate but returns maps of data which is used by most of builder utilities and component generator.
Here migrated to it css and component generator and used it to generate data sources where possible.