-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate server flags to new format #3213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix it firstly in webpack-cli and do release, i.e. supports new format
lets not merge till webpack-cli release, |
Let's finish it, /cc @anshumanv |
oh missed it, yep lets try to finish it today |
Codecov Report
@@ Coverage Diff @@
## master #3213 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 34 34
Lines 1236 1236
Branches 352 352
=======================================
Hits 1179 1179
Misses 51 51
Partials 6 6 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Let's merge this after we finish our options and CLI options to avoid unnecessary work |
Let's close in favor #3325, we need more work here, anyway big thanks |
For Bugs and Features; did you add new tests?
existing
Motivation / Use-Case
we use this format across core flags, cli internal flags
Breaking Changes
need to handle this format in cli, will do it after this version is released.
Additional Info