Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate server flags to new format #3213

Closed
wants to merge 3 commits into from
Closed

fix: migrate server flags to new format #3213

wants to merge 3 commits into from

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

existing

Motivation / Use-Case

we use this format across core flags, cli internal flags

Breaking Changes

need to handle this format in cli, will do it after this version is released.

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix it firstly in webpack-cli and do release, i.e. supports new format

@anshumanv
Copy link
Member Author

anshumanv commented Apr 21, 2021

lets not merge till webpack-cli release, wip on cli should I make a diff PR for support or we ship it with enable tests one?

@snitin315
Copy link
Member

Let's finish it, /cc @anshumanv

@anshumanv
Copy link
Member Author

oh missed it, yep lets try to finish it today

@anshumanv anshumanv marked this pull request as ready for review May 8, 2021 05:16
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #3213 (e870c1b) into master (297a649) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3213   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files          34       34           
  Lines        1236     1236           
  Branches      352      352           
=======================================
  Hits         1179     1179           
  Misses         51       51           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297a649...e870c1b. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@anshumanv anshumanv requested a review from alexander-akait May 14, 2021 21:27
@alexander-akait
Copy link
Member

Let's merge this after we finish our options and CLI options to avoid unnecessary work

@alexander-akait
Copy link
Member

Let's close in favor #3325, we need more work here, anyway big thanks

@alexander-akait alexander-akait deleted the cli-format branch June 3, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants