refactor: backward compatible flags for dev server #2652
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 95.70% 95.52% -0.19%
==========================================
Files 30 30
Lines 1491 1498 +7
Branches 429 430 +1
==========================================
+ Hits 1427 1431 +4
- Misses 64 67 +3
Continue to review full report at Codecov.
|
|
I don't know how to cover this in tests.. |
We can test after a new release of |
snitin315
changed the title
packages/serve/src/index.ts
Outdated
| // new flag format | ||
| // { flag1: {}, flag2: {} } | ||
| return Object.values(flags); | ||
| })(); |
There was a problem hiding this comment.
I think we can simplify it, I will finish 👍
There was a problem hiding this comment.
Left it because it would be easier to simplify after - #2626, as both configs will be objects so easy merge
alexander-akait
dismissed stale reviews from evenstensberg and snitin315
via
1449e1e
alexander-akait
force-pushed
the
server-flags
branch
from
ccddd6a to
1449e1e
Compare
|
Small refactor |
|
|
||
| // New options format | ||
| // { flag1: {}, flag2: {} } | ||
| return Object.keys(options).map((key) => { |
There was a problem hiding this comment.
We will avoid it after switch on object options (part of perf)
What kind of change does this PR introduce?
fix/feat/refactor?
Did you add tests for your changes?
tested manually, no way to test rn
If relevant, did you update the documentation?
no need I think
Summary
we're migrating all flags to a single format, core/cli built in/server flags so this is to handle backward compatibility with dev server flags in migration to new format, once this is released we can go ahead with the migration
Ref webpack/webpack-dev-server#3213
Does this PR introduce a breaking change?
no
Other information