Make custom properties that are IACVT guaranteed-invalid (II) #28100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 16, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. In order to maintain our current animations behavior related to cycles (see CSSVarCycleInterpolationType), we still need to be able to distinguish between "cyclic" and "invalid for other reasons" from the outside. These two situations are now represented by CSSCyclicVariableValue and CSSInvalidVariableValue, respectively. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: I0e7b529e4ae595c6c327c45b4da1a43be64c1c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2762156 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#863497}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2762156
branch
from
49ae999 to
81ea910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per recent spec change [1], custom properties that are invalid at
computed-value time (IACVT) shall become guaranteed-invalid [2]
if the custom property supports guaranteed-invalid values.
In order to maintain our current animations behavior related to cycles
(see CSSVarCycleInterpolationType), we still need to be able to
distinguish between "cyclic" and "invalid for other reasons" from the
outside. These two situations are now represented by
CSSCyclicVariableValue and CSSInvalidVariableValue, respectively.
[1] w3c/csswg-drafts#6006
[2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value
Fixed: 1110188
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ
Change-Id: I0e7b529e4ae595c6c327c45b4da1a43be64c1c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2762156
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#863497}