[css-variables-1] Custom props that are IACVT become guaranteed-invalid #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Issue 5370.
|
cc @tabatkins |
|
Thanks for writing this up, @andruud ! |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 5, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734621 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#860161}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 5, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734621 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#860161}
pull bot
pushed a commit
to luojiguicai/chromium
that referenced
this pull request
Mar 5, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734621 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#860161}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2021
…aranteed-invalid, a=testonly Automatic update from web-platform-tests Make custom properties that are IACVT guaranteed-invalid Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734621 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#860161} -- wpt-commits: 0d5b3606745216381bf97decbd3d0177f9d7f697 wpt-pr: 27899
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 15, 2021
…aranteed-invalid, a=testonly Automatic update from web-platform-tests Make custom properties that are IACVT guaranteed-invalid Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734621 Reviewed-by: Xiaocheng Hu <xiaochenghchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/master{#860161} -- wpt-commits: 0d5b3606745216381bf97decbd3d0177f9d7f697 wpt-pr: 27899 UltraBlame original commit: 632b903fc0d9ad3336667795486e8b35aab68976
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 15, 2021
…aranteed-invalid, a=testonly Automatic update from web-platform-tests Make custom properties that are IACVT guaranteed-invalid Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734621 Reviewed-by: Xiaocheng Hu <xiaochenghchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/master{#860161} -- wpt-commits: 0d5b3606745216381bf97decbd3d0177f9d7f697 wpt-pr: 27899 UltraBlame original commit: 632b903fc0d9ad3336667795486e8b35aab68976
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 15, 2021
…aranteed-invalid, a=testonly Automatic update from web-platform-tests Make custom properties that are IACVT guaranteed-invalid Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: Ibfbb0c641abaf29f099e082115d5f04f77637840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734621 Reviewed-by: Xiaocheng Hu <xiaochenghchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/master{#860161} -- wpt-commits: 0d5b3606745216381bf97decbd3d0177f9d7f697 wpt-pr: 27899 UltraBlame original commit: 632b903fc0d9ad3336667795486e8b35aab68976
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 16, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. In order to maintain our current animations behavior related to cycles (see CSSVarCycleInterpolationType), we still need to be able to distinguish between "cyclic" and "invalid for other reasons" from the outside. These two situations are now represented by CSSCyclicVariableValue and CSSInvalidVariableValue, respectively. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: I0e7b529e4ae595c6c327c45b4da1a43be64c1c88
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 16, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. In order to maintain our current animations behavior related to cycles (see CSSVarCycleInterpolationType), we still need to be able to distinguish between "cyclic" and "invalid for other reasons" from the outside. These two situations are now represented by CSSCyclicVariableValue and CSSInvalidVariableValue, respectively. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: I0e7b529e4ae595c6c327c45b4da1a43be64c1c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2762156 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#863497}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 16, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. In order to maintain our current animations behavior related to cycles (see CSSVarCycleInterpolationType), we still need to be able to distinguish between "cyclic" and "invalid for other reasons" from the outside. These two situations are now represented by CSSCyclicVariableValue and CSSInvalidVariableValue, respectively. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: I0e7b529e4ae595c6c327c45b4da1a43be64c1c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2762156 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#863497}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Mar 17, 2021
Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. In order to maintain our current animations behavior related to cycles (see CSSVarCycleInterpolationType), we still need to be able to distinguish between "cyclic" and "invalid for other reasons" from the outside. These two situations are now represented by CSSCyclicVariableValue and CSSInvalidVariableValue, respectively. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: I0e7b529e4ae595c6c327c45b4da1a43be64c1c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2762156 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#863497}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 19, 2021
…aranteed-invalid (II), a=testonly Automatic update from web-platform-tests Make custom properties that are IACVT guaranteed-invalid (II) Per recent spec change [1], custom properties that are invalid at computed-value time (IACVT) shall become guaranteed-invalid [2] if the custom property supports guaranteed-invalid values. In order to maintain our current animations behavior related to cycles (see CSSVarCycleInterpolationType), we still need to be able to distinguish between "cyclic" and "invalid for other reasons" from the outside. These two situations are now represented by CSSCyclicVariableValue and CSSInvalidVariableValue, respectively. [1] w3c/csswg-drafts#6006 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value Fixed: 1110188 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Change-Id: I0e7b529e4ae595c6c327c45b4da1a43be64c1c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2762156 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#863497} -- wpt-commits: 423f1072b46b978c1e280452e647394475542fa3 wpt-pr: 28100
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 4, 2021
…d. r=boris This effectively backs out bug 1623396. See: w3c/csswg-drafts#6006 https://drafts.csswg.org/css-variables/#guaranteed-invalid-value And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Depends on D116459 Differential Revision: https://phabricator.services.mozilla.com/D116460
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jun 9, 2021
…d. r=boris This effectively backs out bug 1623396. See: w3c/csswg-drafts#6006 https://drafts.csswg.org/css-variables/#guaranteed-invalid-value And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Depends on D116459 Differential Revision: https://phabricator.services.mozilla.com/D116460
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Jun 7, 2023
This effectively backs out bug 1623396. See: w3c/csswg-drafts#6006 https://drafts.csswg.org/css-variables/#guaranteed-invalid-value And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Depends on D116459 Differential Revision: https://phabricator.services.mozilla.com/D116460
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Jun 7, 2023
This effectively backs out bug 1623396. See: w3c/csswg-drafts#6006 https://drafts.csswg.org/css-variables/#guaranteed-invalid-value And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Depends on D116459 Differential Revision: https://phabricator.services.mozilla.com/D116460
Loirooriol
pushed a commit
to Loirooriol/servo
that referenced
this pull request
Jun 9, 2023
This effectively backs out bug 1623396. See: w3c/csswg-drafts#6006 https://drafts.csswg.org/css-variables/#guaranteed-invalid-value And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Depends on D116459 Differential Revision: https://phabricator.services.mozilla.com/D116460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5370.