fix(remote-cache): use posix paths for tar archives #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ensure that archives generated for remote caching have the directory structure preserved in a consistant manner to what is generated on linux/mac Fixes: vercel#801
thebanjomatic
requested review from
jaredpalmer,
gsoltis and
gaspar09
as code owners
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/ExtupEfWjmmXx9ohiDw2L2JBdhpk |
gsoltis
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ensure that archives generated for remote caching have the directory
structure preserved in a consistant manner to what is generated on linux/mac
Fixes: #801
PR #891 I believe fixes the hash calculation so that a remote-cache generated on linux or mac can be consumed on windows and no longer results in a cache miss, but I still have concerns about consuming archives generated on windows from the linux environment. In particular, these paths are coming from globby and don't pass through the normalization from the linked PR, so they are still os-dependent.
I have encountered some problems with builds failing in GH Actions because dependencies that should have been built already were not found when I had previously built those projects on my windows machine. I believe this PR should fix the problem but I haven't had the chance to try reproducing the existing issue to verify that this fixes it. I might be able to get that done later today, but I wanted to get a PR up sooner rather than later