-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize paths coming from ls tree #891
Normalize paths coming from ls tree #891
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/FAh9Mg25SWbUEWQiMqxN2VhsfhCE |
Not sure if error is related |
Will this also address the root cause of Issue #801? |
@thebanjomatic i believe so |
Thanks, I pulled down and built the branch locally and can confirm that this does indeed appear to be the case if you want to tag the issue. That being said, it might still be a good idea to add the filesToBeCached := globby.GlobFiles(pt.pkg.Dir, outputs, ignore) Maybe |
Github Actions seems to be degraded at the moment. Will investigate test failures once it sorts itself out. |
Looks like test failures were due to Github Actions issues. |
This should ensure that archives generated for remote caching have the directory structure preserved in a consistant manner to what is generated on linux/mac Fixes: #801 PR #891 I believe fixes the hash calculation so that a remote-cache generated on linux or mac can be consumed on windows and no longer results in a cache miss, but I still have concerns about consuming archives generated on windows from the linux environment. In particular, these paths are coming from globby and don't pass through the normalization from the linked PR, so they are still os-dependent. I have encountered some problems with builds failing in GH Actions because dependencies that should have been built already were not found when I had previously built those projects on my windows machine. I believe this PR should fix the problem but I haven't had the chance to try reproducing the existing issue to verify that this fixes it. I might be able to get that done later today, but I wanted to get a PR up sooner rather than later
Note: