Implement --filter RFC

[gsoltis]

Implement #105

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/HXZTf93tyXZqrnkDKL5ysm5pw8Tm
✅ Preview: https://turbo-site-git-gsoltis-filter.vercel.sh

[jaredpalmer]

Should we change the pipeline delimiter for topological relationship to be ... instead of ^? We would need a codemod

[weyert]

Looking really powerful! I can't wait to try this out in the canary :)

[gsoltis]

Some review notes:

• Some pieces of the RFC are not yet implemented. In particular, --test-pattern and --filter-prod are not implemented. The existing --ignore flag is respected as --changed-files-ignore-pattern.
• Docs are still a TODO. I'm open to suggestions on how much detail to include in the help text for run. I suspect that including a full syntax reference for filters might be too much, but we ought to have a link to the docs at the very least.
• We added an extra piece of syntax to pnpm's syntax: the ability to specify leading ... before a commit reference. When specified, we use a different algorithm for selecting packages: first we filter all packages that match package and directory filters. Second, we further filter that list of packages to include only the packages whose dependencies have changed since the specified commit. This enables the usecase of selecting a package if it or any of its dependencies have changed.
• The algorithm in filter.go is largely a port of the corresponding filtering in pnpm, with the exception of filterSubtreesWithSelector, which implements the above additional feature.
• filter_test.go is largely a port of pnpm's test for filter
• parse_target_selector_test.go is a port of pnpm's test for parsing selectors
• match_test.go is a port of pnpm's matcher test

[weyert]

@gsoltis How much do you think is left for this PR? I am wondering if I could help you in someway

[gsoltis]

@weyert Thanks for your interest. Probably the most helpful thing right now would be some QA. I've ported a good chunk of the tests from the equivalent pnpm modules, but it's helpful to try with actual commands someone would run. So, can you try building from this branch and see if you are able to express the commands you would want? Especially with --dry, you should be able to verify that the targets you expect are getting run.

[weyert]

@gsoltis Yeah, I have build for the Mac. I haven’t been able to make a build for Linux yet. Maybe a canary build would help to test this PR? Can imagine that would be useful for @pablo-abc too

[weyert]

@gsoltis Will it support the upcoming --filter change in NPM v7?

Filtering by path is done by globs.

In pnpm v6, in order to pick packages under a certain directory, the following filter was used: --filter=./apps

In pnpm v7, a glob should be used: --filter=./apps/**

Source: https://github.com/pnpm/pnpm/releases/tag/v7.0.0-beta.2

[rxliuli]

I would like to release one version first and the next version to support the changes in pnpm v7, we have been waiting for this feature for too long