Validate graphs before execution #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/CBnK6CEQ4tEJPcMjhBGwvoiTEaqv |
|
@jaredpalmer Hi Jared. Can we ignore cyclic graph in peerDeps and only validate for deps and devDeps ? Currently it hungs up the process even when peerDeps have circular dependency. |
Tried adopting turbo on MikroORM monorepo, and I believe I got the exact same issue, only one package that has no dependencies at all gets built, then it gets stuck. Currently using lerna with yarn workspaces and that builds just fine. |
|
Will revisit after #887 |
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
### turbo tracing in pnpm projects How pnpm link packages:  After turbo tracing: ``` dist ├── crates │ └── turbopack │ └── tests │ └── node-file-trace │ ├── integration │ └── node_modules │ └── better-sqlite3 -> ../../../../../node_modules/.pnpm/better-sqlite3@7.6.2/node_modules/better-sqlite3 └── node_modules └── .pnpm ├── better-sqlite3@7.6.2 │ └── node_modules │ ├── better-sqlite3 │ │ ├── build │ │ │ └── Release │ │ └── lib │ │ └── methods │ └── bindings -> ../../bindings@1.5.0/node_modules/bindings ├── bindings@1.5.0 │ └── node_modules │ ├── bindings │ └── file-uri-to-path -> ../../file-uri-to-path@1.0.0/node_modules/file-uri-to-path └── file-uri-to-path@1.0.0 └── node_modules └── file-uri-to-path ``` No more **global .pnpm store**. The directory link will follow the original path created by pnpm.
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
### turbo tracing in pnpm projects How pnpm link packages:  After turbo tracing: ``` dist ├── crates │ └── turbopack │ └── tests │ └── node-file-trace │ ├── integration │ └── node_modules │ └── better-sqlite3 -> ../../../../../node_modules/.pnpm/better-sqlite3@7.6.2/node_modules/better-sqlite3 └── node_modules └── .pnpm ├── better-sqlite3@7.6.2 │ └── node_modules │ ├── better-sqlite3 │ │ ├── build │ │ │ └── Release │ │ └── lib │ │ └── methods │ └── bindings -> ../../bindings@1.5.0/node_modules/bindings ├── bindings@1.5.0 │ └── node_modules │ ├── bindings │ └── file-uri-to-path -> ../../file-uri-to-path@1.0.0/node_modules/file-uri-to-path └── file-uri-to-path@1.0.0 └── node_modules └── file-uri-to-path ``` No more **global .pnpm store**. The directory link will follow the original path created by pnpm.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
### turbo tracing in pnpm projects How pnpm link packages:  After turbo tracing: ``` dist ├── crates │ └── turbopack │ └── tests │ └── node-file-trace │ ├── integration │ └── node_modules │ └── better-sqlite3 -> ../../../../../node_modules/.pnpm/better-sqlite3@7.6.2/node_modules/better-sqlite3 └── node_modules └── .pnpm ├── better-sqlite3@7.6.2 │ └── node_modules │ ├── better-sqlite3 │ │ ├── build │ │ │ └── Release │ │ └── lib │ │ └── methods │ └── bindings -> ../../bindings@1.5.0/node_modules/bindings ├── bindings@1.5.0 │ └── node_modules │ ├── bindings │ └── file-uri-to-path -> ../../file-uri-to-path@1.0.0/node_modules/file-uri-to-path └── file-uri-to-path@1.0.0 └── node_modules └── file-uri-to-path ``` No more **global .pnpm store**. The directory link will follow the original path created by pnpm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #262
In order to leverage our Dag library's existing Cycle detection, we also actually need to reverse the direction of edge connections and possibly the walk direction