How do I build Storybook inside starter ui package?

[fibonacid]

What version of Turborepo are you using?

1.0.17

What version of Node are you using?

v14.17.6

What version of Yarn are you using?

1.22.4

Describe the Bug

Can't run build-storybook on ui package using turbo.

Expected Behavior

Running build-storybook from ui package works fine.

yarn --cwd packages/ui build-storybook

Running build-storybook using turbo gets stuck forever.

yarn build-storybook

To Reproduce

Clone example repo

git clone https://github.com/fibonacid/turborepo-build-storybook-bug
cd turborepo-build-storybook-bug

Install dependencies

yarn install

Run command

yarn build-storybook

[crutchcorn]

I'm experiencing the same in my project. Likewise with start-storybook. However, if I cd into the directory, it works as-intended

[fibonacid]

I'm experiencing the same in my project. Likewise with start-storybook. However, if I cd into the directory, it works as-intended

If you put the start-storybook task in the turbo config with caching disabled works

[crutchcorn]

I have the following in my pipeline:

      "storybook": {
        "cache": false
      },

And it still seems to hang with the script:

    "storybook": "start-storybook -p 6007"

Is that what you meant @fibonacid ?

[rishabh2712]

Facing same issue. The thread is getting stuck at the start-storybook script, however running fine incase we gone down into the target folder.

[fibonacid]

I have the following in my pipeline:

      "storybook": {
        "cache": false
      },

And it still seems to hang with the script:

    "storybook": "start-storybook -p 6007"

Is that what you meant @fibonacid ?

Yeah that works for me.

btw, the storybook versions i'm using are

    "@storybook/addon-actions": "^6.4.9",
    "@storybook/addon-essentials": "^6.4.9",
    "@storybook/addon-links": "^6.4.9",
    "@storybook/react": "^6.4.9",

[crutchcorn]

These are mine, seems pretty similar:

"@storybook/addon-essentials": "^6.4.9",
"@storybook/builder-webpack5": "^6.4.9",
"@storybook/manager-webpack5": "^6.4.9",
"@storybook/react": "^6.4.9"

[7iomka]

Share me please example repo with fixed problem if it fixed)
Thanks)

[fibonacid]

@7iomka Haven't found a fix for the build-storybook script yet. If anyone has a solution can submit a PR to the bug report repo

git clone https://github.com/fibonacid/turborepo-build-storybook-bug

[guillaumewuip]

@jaredpalmer as we have a reproductible repo, can this be converted back to an issue?

[fibonacid]

@crutchcorn Can you try to see if you can run start-storybook with turbo using the example repo i created?
Maybe your problem has something to do with your yarn or node version.

[crutchcorn]

I can reproduce this in this example repository. (Both for start-storybook and build-storybook)

For reference, I'm using node@14.18.2 and yarn 1.22.17.

I've also experienced this issue using node@16.13.1

What versions are you using?

[guillaumewuip]

I'm facing the same issue with a big storybook in one of my company's monorepo.

I also have the same problem with another package that is built with webpack (I had to remove the --progress option to make it work) and another one that is stuck when I try to run tests (~4000 tests) with jest (don't found a fix yet). Turborepo is stuck forever at ~100% CPU.

Could it be related at how turborepo handle stdout / stderr? My three commands outputs a lot of text to the screen.

[kylemh]

Hey @jaredpalmer! Why was this moved to discussions? Storybook is going to be a pretty popular tool to integrate with and currently the out-of-box build script causes Turborepo to freeze.

[MangoChris]

I would even go one step further and say that for projects large enough to need monorepo’s it’s practically standard.

On Thu, 23 Dec 2021 at 18:00, Kyle Holmberg ***@***.***> wrote: Hey @jaredpalmer <https://github.com/jaredpalmer>! Why was this moved to discussions? Storybook is going to be a pretty popular tool to integrate with and currently the out-of-box build script causes Turborepo to freeze. — Reply to this email directly, view it on GitHub <#374 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIQIGXCLLUNDGGR2EY3O4DUSNPSZANCNFSM5KO24GLA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

--

…

_________________ *Chris Brown* *CEO* ***@***.*** ***@***.***>* *Schedule a Call <https://calendly.com/mangomap-chris/intro/>* *LinkedIn <https://uk.linkedin.com/in/chrisincambo>*

[7iomka]

Move this to issues, please

[jaredpalmer]

This is likely due to either #336 or #292.

[jaredpalmer]

This is now being tracked in #422

[supaspoida]

Ahead of a fix, you could try the following flags w/your storybook commands:

  "scripts": {
    "storybook": "start-storybook --ci -p 6006",
    "build-storybook": "build-storybook --quiet -o dist"
  }

The important bits are --ci and --quiet. I tried these changes on the reproduction repo and they worked for me.

[fibonacid]

@supaspoida Works for me!

[kylemh]

Although it's not needed for me in dev. Just build.

[leerob]

Update: We now have a design system example using:

• 🏎 Turborepo — High-performance build system for Monorepos
• 🚀 React — JavaScript library for user interfaces
• 🛠 Tsup — TypeScript bundler powered by esbuild
• 📖 Storybook — UI component environment powered by Vite

https://github.com/vercel/turborepo/tree/main/examples/design-system

[kylemh]

Hey @leerob

I wanted to suggest 2 design system examples. The one you have is great, but if I'm trying to avoid versioning/bundling by using next-transpile-modules in one of the consumers there are some things that should be done in the example to help any people attempting it. I outline the issues here under "Storybook and consequences".

If 2 design system examples seems overkill, an alternative could simply be mentioned and discussed in the README of the example... maybe as a FAQ?

---

As an aside, the new design-system example has the documentation as an application that lives outside of the actual package. It feels like this would be slower than having the Storybook instance live within the package itself since a bundle step would be required as-is.

[jnarowski]

Storybook 6.5 does not seem to be hitting the cache. I followed config from the design system exactly but it's missing the cache every time I build.

[kylemh]

should make a new issue no?