Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing locale keys (still need translated) #1000

Closed
wants to merge 46 commits into from
Closed

Add missing locale keys (still need translated) #1000

wants to merge 46 commits into from

Conversation

amosfolz
Copy link
Contributor

Generated missing locale keys for all languages using PR #992 locale:fix-keys command.

The empty key values were populated using en_US and can be identified via locales:missing-values command.

(also wanted to check these files will pass style-ci check)

Silic0nS0ldier and others added 24 commits February 16, 2019 15:18
@Silic0nS0ldier
Removed unnecessary usage of ClassMapper->staticMethod
55bb88d
@Silic0nS0ldier
Merge branch 'develop-jordan' into develop-4.3-jordan
319676c
@Silic0nS0ldier
userfrosting#908 Require at least PHP 7.1
77d93ad
@Silic0nS0ldier
Merge branch 'master' into develop-4.3-jordan
10fa02c
@Silic0nS0ldier
Removed build containers from docker-compose.yml in favour of separ…
1d674fe 
…ate commands
@Silic0nS0ldier
Merge branch 'hotfix' into feature-docker-refinements
03191b3
@Silic0nS0ldier
Merge branch 'master' into feature-docker-refinements
a49cfd0
@Silic0nS0ldier
Fixed styling issues with PHP CS Fixer and visual inspection of results
1da7d3c
@Silic0nS0ldier
Merge pull request userfrosting#959 from userfrosting/feature-docker-…
aabe7ce 
…refinements

Removed build containers from `docker-compose.yml` in favour of separate commands
@lcharette
Merge branch 'hotfix' into develop
fc00e07
@lcharette
Merge branch 'develop' into develop-4.3-jordan
a6abdec
@lcharette
Fix Styling
4a450e0
@lcharette
Fix failed tests
f431f56
@lcharette
Merge pull request userfrosting#937 from userfrosting/develop-4.3-jordan
b31d6ac 
PHP 7.1 Optimisations
@lcharette
bake command return error if account sprinkle is not included - Fix u…
914d3db 
…serfrosting#944
@lcharette
Fix styling
6a2900e
@lcharette
Change required PHP version - Address userfrosting#908
cfa02d2
@lcharette
Merge branch 'hotfix' into develop
55c67ec
@lcharette
Updated custom Eloquent relations for Laravel 5.8 (userfrosting#996)
2190c64 
* Update Laravel version
* Removed deprecated `belongsToManyConstrained`
* Updated Changelog
* Fix styling
* Update sqlite support
* Updated Laravel references
@lcharette
Updated PHPUnit dependency (Ref userfrosting#779)
aab36b0
@lcharette
Updated symfony/console to 4.3
ba9df48
@lcharette
Merge branch 'hotfix' into develop
35ec97c
@lcharette
Merge branch 'develop' into develop-feature-updatedDependencies
4a93b9c
@amosfolz
Add missing locale keys (still need translated)
cdd8a12
@lcharette lcharette added the internationalization Related to the localization feature label Jun 20, 2019
@lcharette lcharette added this to the 4.3.0 milestone Jun 20, 2019
lcharette and others added 15 commits June 22, 2019 22:54
@lcharette
Fix issue with Symfony/Console throwing error when empty array is pas…
8d2d734 
…sed to `writeln`
@lcharette
Fix Styling
d8d2ab0
@lcharette
Merge pull request #1 from amosfolz/update-league-csv
7429ef9 
Update league/csv
@amosfolz
Update CHANGELOG.md
fb62130
@amosfolz
Merge branch 'develop-feature-updatedDependencies' into develop-featu…
2e4d62a 
…re-update-nikic-php-parser
@amosfolz
Update PHPMailer to 6.0.7
40f05c1
@amosfolz
Update composer.json
199b0f6
@lcharette
Merge pull request #3 from amosfolz/develop-feature-update-phpmailer
e2de173 
Update PHPMailer to 6.0.7
@lcharette
Fix Styling
048a56d
@lcharette
Merge branch 'develop-feature-updatedDependencies' into develop-featu…
894747f 
…re-update-nikic-php-parser
@lcharette
Merge pull request #2 from amosfolz/develop-feature-update-nikic-php-…
ddc2357 
…parser

update nikic/php-parser
@lcharette
Updated vlucas/phpdotenv to 3.4.0
2de2df9
@lcharette
Merge pull request userfrosting#999 from lcharette/develop-feature-up…
1cf9ca8 
…datedDependencies

Update to the latest Laravel & Composer Packages
@lcharette
Merge branch 'hotfix' into develop
37a4a15
@amosfolz
Merge branch 'develop' into add-missing-locale-keys
963cc86
@codecov
Copy link

codecov bot commented Jun 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (hotfix@c3ab9a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1000   +/-   ##
=========================================
  Coverage          ?   68.34%           
  Complexity        ?     2141           
=========================================
  Files             ?      159           
  Lines             ?     7289           
  Branches          ?        0           
=========================================
  Hits              ?     4982           
  Misses            ?     2307           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ab9a6...963cc86. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 30, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (hotfix@c3ab9a6). Click here to learn what that means.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1000   +/-   ##
=========================================
  Coverage          ?   66.93%           
  Complexity        ?     1913           
=========================================
  Files             ?      159           
  Lines             ?     6684           
  Branches          ?        0           
=========================================
  Hits              ?     4474           
  Misses            ?     2210           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
...count/src/Database/Migrations/v400/GroupsTable.php 100% <ø> (ø) 3 <0> (?)
.../Database/Migrations/v400/PermissionRolesTable.php 100% <ø> (ø) 3 <0> (?)
...ore/src/Database/Migrations/v400/SessionsTable.php 100% <ø> (ø) 3 <0> (?)
...rc/Database/Migrations/v400/VerificationsTable.php 100% <ø> (ø) 3 <0> (?)
...ccount/src/Database/Migrations/v400/RolesTable.php 100% <ø> (ø) 3 <0> (?)
...src/Database/Migrations/v400/PersistencesTable.php 100% <ø> (ø) 3 <0> (?)
...ccount/src/Database/Migrations/v400/UsersTable.php 100% <ø> (ø) 3 <0> (?)
...t/src/Database/Migrations/v400/ActivitiesTable.php 100% <ø> (ø) 3 <0> (?)
...nt/src/Database/Migrations/v400/RoleUsersTable.php 100% <ø> (ø) 3 <0> (?)
...c/Database/Migrations/v400/PasswordResetsTable.php 100% <ø> (ø) 3 <0> (?)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ab9a6...44c9d4b. Read the comment docs.

@lcharette lcharette changed the base branch from hotfix to develop July 1, 2019 14:44
@lcharette lcharette changed the base branch from develop to hotfix July 1, 2019 14:47
@amosfolz
Copy link
Contributor Author

amosfolz commented Jul 1, 2019

This branch/PR has become very dirty. Changes have been moved to PR #1006

@amosfolz amosfolz closed this Jul 1, 2019
@amosfolz amosfolz deleted the add-missing-locale-keys branch July 1, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internationalization Related to the localization feature
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amosfolz @lcharette @Silic0nS0ldier