Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated custom Eloquent relations for Laravel 5.8 #996

Merged
merged 15 commits into from
Jun 11, 2019

Conversation

lcharette
Copy link
Member

  • Updated custom Eloquent relations for Laravel 5.8
  • Removed belongsToManyConstrained (deprecated in 4.1.6)

Related to Issue #907

@lcharette lcharette added the compatibility Compatibility issue with other framework, features label Jun 7, 2019
@lcharette lcharette added this to the 4.3.0 milestone Jun 7, 2019
@lcharette lcharette requested a review from alexweissman June 7, 2019 02:52
@lcharette lcharette self-assigned this Jun 7, 2019
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #996 into develop will increase coverage by 0.27%.
The diff coverage is 87.27%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #996      +/-   ##
=============================================
+ Coverage      66.83%   67.11%   +0.27%     
+ Complexity      2082     2073       -9     
=============================================
  Files            160      159       -1     
  Lines           6793     6753      -40     
=============================================
- Hits            4540     4532       -8     
+ Misses          2253     2221      -32
Impacted Files Coverage Δ Complexity Δ
...t/src/Database/Migrations/v400/ActivitiesTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...ccount/src/Database/Migrations/v400/RolesTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...count/src/Database/Migrations/v400/GroupsTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...nt/src/Database/Migrations/v400/RoleUsersTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
.../Database/Migrations/v400/PermissionRolesTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...src/Database/Migrations/v400/PersistencesTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...c/Database/Migrations/v400/PasswordResetsTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...ore/src/Database/Migrations/v400/SessionsTable.php 100% <ø> (ø) 4 <0> (ø) ⬇️
.../src/Database/Migrations/v400/PermissionsTable.php 100% <ø> (ø) 5 <0> (ø) ⬇️
app/sprinkles/core/src/Csrf/SlimCsrfProvider.php 81.48% <ø> (ø) 12 <0> (ø) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c67ec...394b73c. Read the comment docs.

@lcharette lcharette merged commit 2190c64 into userfrosting:develop Jun 11, 2019
@lcharette lcharette deleted the feature-develop-Laravel5.8 branch June 11, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility issue with other framework, features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant