rename Client folder

[idseefeld]

rename Client folder, replace example by UmbracoExtension to get unique names

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes issue 18609

Steps to reproduce

1. Create two packages with the Umbraco Extension template
2. Change some text the render() method in one of the example dashboard.element.ts
3. Create the packages for your local NuGet source
4. Install both packages into a new Umbraco WebSite project
5. Run and see that you don't two different dashboards. In Dev Tools: Sources tab you'll see just one Client folder etc.

Expected result / actual result

I would expect from such template that it does all necessary changes to produce a unique starting point for a new package.

Description

Essentially, I added two .cmd files npm-scripts.cmd and UmbracoExtension\execute-npm-commands.cmd, renamed the Client folder into UmbracoExtension and changed the executable to npm-scripts.cmd without args in the UmbracoExtension.template.config\template.json file. The contents of the .cmd files are taken into account by the template engine. This is also suggested as a solution here: dotnet/templating#765

[github-actions]

Hi there @idseefeld, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @idseefeld!

Thanks for your PR to fix #18609, where the Umbraco Extension Template may cause issues with conflicts in packages.

One of the Core Collaborators team will review this as soon as possible - it also seems like one that we want HQ to double check, so I'll contact them about it.

Best wishes

Emma

[emmagarland]

Hi @idseefeld

I've had a chat with HQ and we're going to have to close the PR in it's current state. We will need to spend some time reviewing your original raised issue #18609 first, and have a think about the best solution.

Hopefully some elements of this PR will be able to be kept once a best solution is in place.

Thanks again for your contribution, and hopefully this can be revisited in future.

Emma