Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbraco Extension Template may lead to conflicts in packages #18609

Open
idseefeld opened this issue Mar 9, 2025 · 1 comment
Open

Umbraco Extension Template may lead to conflicts in packages #18609

idseefeld opened this issue Mar 9, 2025 · 1 comment

Comments

@idseefeld
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.2.3

Bug summary

Assume two developers start there package with the Umbraco Extension template and let some of the configuration unchanged. Then these packages may cause conflicts and override there methods etc.

Specifics

Issue Details

There are some places where the examples need to be changed. And I think these are not obvious to beginners.

  1. For example the Client folder is not changed to something unique like the package name.
  2. Same for customElement name and maybe the related class name in dashboards.element.ts
  3. Finally meta:pathname and meta:label in dashboards/manifest.ts should be changed too
  4. Even mor tricky might be export const client = createClient(createConfig()); in api/services.gen.ts. I am not sure if this is an issue. It seems to work and did not see errors in Dev Tools.

My proposal for a solution

I have manually changed the above mentioned names and here some screenshot how the Dev Tools should look like:

Image

Image

Image

Steps to reproduce

  1. Create two packages with the Umbraco Extension template
  2. Change some text the render() method in one of the example dashboard.element.ts
  3. Create the packages for your local NuGet source
  4. Install both packages into a new Umbraco WebSite project
  5. Run and see that you don't two different dashboards. In Dev Tools: Sources tab you'll see just one Client folder etc.

Expected result / actual result

I would expect from such template that it does all necessary changes to produce a unique starting point for a new package.

At least there should be a detailed checklist for what needs to be changed. But we all know that such lists tend to be overlooked or ignored.

Finally I am pretty sure this issue could be solved and I'll try to provide a possible solution...

Copy link

github-actions bot commented Mar 9, 2025

Hi there @idseefeld!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants