Add 'netcdf' and 'grib2' to IC input source options in regional IC/LBC routines (re-opened) #567

chan-hoo · 2021-05-10T19:17:52Z

Description

Add 'netcdf' and 'grib2' to the IC input source options in the regional IC/LBC routines of 'atmos_cubed_sphere'.
Re-opend PR of Add 'netcdf' and 'grib2' to input 'source' options in regional IC/LBC routines #526.

Issue(s) addressed

Fixes Regional IC/LBC routines in atmos_cubed_sphere allow only 'nemsio' as global attribute 'source' #523
Fixes Regional IC/LBC routines in atmos_cubed_sphere allow only 'nemsio' as global attribute 'source' NOAA-EMC/fv3atm#281
Fixes (dev/emc) Regional IC/LBC routines allows only gfs nemsio string as global attribute source (reopened) NOAA-GFDL/GFDL_atmos_cubed_sphere#97

Testing

Passed the regression test of the ufs weather model on WCOSS (dell/cray) and Hera with intel compiler.
Completed a LAMDA test successfully with 'netcdf' input files from GFS.

Regression tests:

Dependencies

Contributors

@JamesAbeles-NOAA, @EricRogers-NOAA

MinsukJi-NOAA · 2021-05-10T19:33:14Z

This is a new PR for #526

on-behalf-of @ufs-community

BrianCurtis-NOAA · 2021-05-11T01:57:37Z

Machine: jet
Compiler: intel
Job: RT
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/638266410/20210510210015/ufs-weather-model
Please manually delete: /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_261147
Test cpld_bmarkfrac_wave_v16 025 failed failed
Test cpld_bmarkfrac_wave_v16 025 failed in run_test failed
Test cpld_bmarkfrac_v16_nsst 021 failed in run_test failed
Test cpld_bmarkfrac 018 failed in run_test failed
Test cpld_bmarkfrac_v16 020 failed in run_test failed
Test compile 013 failed failed
Test compile 016 failed failed
Test fv3_esg_HAFS_v0_hwrf_thompson 076 failed in run_test failed
Test fv3_gfsv16_csawmgt 072 failed in run_test failed
Test fv3_gfsv16_csawmg 071 failed in run_test failed
Test datm_debug_cfsr 102 failed in run_test failed
Test datm_mx025_cfsr 100 failed in run_test failed
Test datm_mx025_gefs 101 failed in run_test failed
Please make changes and add the following label back:
jet-intel-RT

…ic_string

BrianCurtis-NOAA · 2021-05-11T13:51:59Z

Machine: orion
Compiler: intel
Job: RT
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/638266410/20210511071508/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_20636
Test cpld_ca 008 failed in run_test failed
Test cpld_decomp 006 failed in run_test failed
Test cpld_debug 028 failed in run_test failed
Test cpld_controlfrac 003 failed in run_test failed
Test cpld_control_c384 013 failed in run_test failed
Test cpld_control_wave 027 failed in run_test failed
Test cpld_2threads 005 failed in run_test failed
Test cpld_satmedmf 007 failed in run_test failed
Test cpld_debugfrac 029 failed in run_test failed
Test cpld_control 001 failed in run_test failed
Test cpld_controlfrac_c192 011 failed in run_test failed
Test cpld_controlfrac_c384 015 failed in run_test failed
Test fv3_lndp 043 failed in run_test failed
Test fv3_stochy 041 failed in run_test failed
Test fv3_wrtGauss_nemsio_c192 040 failed in run_test failed
Test fv3_iau 044 failed in run_test failed
Test fv3_restart 033 failed in run_test failed
Test fv3_read_inc 034 failed in run_test failed
Test fv3_lheatstrg 045 failed in run_test failed
Test cpld_control_c192 009 failed in run_test failed
Test fv3_ca 042 failed in run_test failed
Test cpld_bmarkfrac_v16_nsst 022 failed in run_test failed
Test cpld_bmarkfrac_wave_v16 026 failed in run_test failed
Test cpld_bmark_wave 024 failed in run_test failed
Test cpld_bmark 017 failed in run_test failed
Test cpld_bmarkfrac_wave 025 failed in run_test failed
Test cpld_bmarkfrac_v16 021 failed in run_test failed
Test cpld_bmarkfrac 019 failed in run_test failed
Test fv3_wrtGauss_nemsio 039 failed in run_test failed
Test fv3_2threads 032 failed in run_test failed
Test fv3_gfdlmprad_noahmp 058 failed in run_test failed
Test fv3_gfdlmprad_gwd 057 failed in run_test failed
Test fv3_gfdlmp 056 failed in run_test failed
Test fv3_satmedmfq 061 failed in run_test failed
Test fv3_satmedmf 060 failed in run_test failed
Test fv3_csawmg 059 failed in run_test failed
Test fv3_regional_quilt_netcdf_parallel 054 failed in run_test failed
Test fv3_regional_quilt 052 failed in run_test failed
Test fv3_regional_quilt_hafs 053 failed in run_test failed
Test fv3_regional_quilt_RRTMGP 055 failed in run_test failed
Test fv3_regional_control 050 failed in run_test failed
Please make changes and add the following label back:
orion-intel-RT

DeniseWorthen · 2021-05-11T14:17:31Z

These all show " CANCELLED by 8555" when they tried to run. But I don't see any real clue what that means.

Slurm unknown status -. Check sacct ...
2004946         CANCELLED by 8555         rt_20636_001
32 min. TEST 001 cpld_control is CANCELLED,  status: - jobid 2004946

MinsukJi-NOAA · 2021-05-11T14:19:32Z

These all show " CANCELLED by 8555" when they tried to run. But I don't see any real clue what that means.
Slurm unknown status -. Check sacct ...
2004946         CANCELLED by 8555         rt_20636_001
32 min. TEST 001 cpld_control is CANCELLED,  status: - jobid 2004946

@BrianCurtis-NOAA canceled all jobs I submitted this morning at my request. I identified 10 failed tests from yesterday on Orion, and just submitted rt jobs.

DeniseWorthen · 2021-05-11T14:20:11Z

Oh, I understand now. I thought these were more failing jobs.

MinsukJi-NOAA · 2021-05-12T12:51:52Z

@chan-hoo, once the related fv3 PR (NOAA-EMC/fv3atm#297) is committed, you can change the fv3 pointer in gitmodules.

junwang-noaa · 2021-05-12T13:24:47Z

fv3 PR is committed

…

On Wed, May 12, 2021 at 8:52 AM Minsuk Ji ***@***.***> wrote: @chan-hoo <https://github.com/chan-hoo>, once the related fv3 PR ( NOAA-EMC/fv3atm#297 <NOAA-EMC/fv3atm#297>) is committed, you can change the fv3 pointer in gitmodules. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#567 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TLJ2OF5S7ACQNUPGLTTNJ2X5ANCNFSM44SA47NQ> .

…ic_string

MinsukJi-NOAA · 2021-05-12T13:36:01Z

We are good to go.

climbfuji

I don't see the fv3atm submodule pointer update. Must point to hash 345915a

MinsukJi-NOAA · 2021-05-12T13:39:34Z

I don't see the fv3atm submodule pointer update. Must point to hash 345915a

Good catch, Dom. @chan-hoo, did you submodule sync?

climbfuji

I approve with the understanding that the submodule pointer will be fixed as requested before merging.

MinsukJi-NOAA · 2021-05-12T13:50:00Z

I approve with the understanding that the submodule pointer will be fixed as requested before merging.

It's been done. Kindly check one more time @DomHeinzeller @climbfuji

junwang-noaa · 2021-05-12T14:06:18Z

The revision looks good now.

…-GSL#65) * Update submodule pointer for fv3atm * Copy new Thompson tables from temporary location

* 1)update upp revision to 8ed92cb; 2)read instant model top longwave; 3)output lat/lon of four corner point for rotated lat-lon grid.

…d namelist; set pazi=-13.0 for the RRFS_NA_3km domain (#567)

chan-hoo added 2 commits May 10, 2021 19:09

Update FV3

78109f1

Point to PR of FV3

9be85d9

MinsukJi-NOAA requested review from junwang-noaa, climbfuji and DusanJovic-NOAA May 10, 2021 19:32

MinsukJi-NOAA added hera-intel-RT No Baseline Change No Baseline Change labels May 10, 2021

BrianCurtis-NOAA removed the hera-intel-RT label May 10, 2021

RT JOBS PASSED: hera.intel. Log file uploaded.

1f5995d

on-behalf-of @ufs-community

MinsukJi-NOAA added cheyenne-intel-RT labels May 10, 2021

BrianCurtis-NOAA removed orion-intel-RT labels May 10, 2021

DusanJovic-NOAA approved these changes May 10, 2021

View reviewed changes

BrianCurtis-NOAA added 2 commits May 10, 2021 21:38

RT JOBS PASSED: hera.gnu. Log file uploaded.

85b8677

on-behalf-of @ufs-community

RT JOBS PASSED: cheyenne.intel. Log file uploaded.

3696319

on-behalf-of @ufs-community

MinsukJi-NOAA added the cheyenne-gnu-RT label May 10, 2021

RT JOBS PASSED: gaea.intel. Log file uploaded.

7389f17

on-behalf-of @ufs-community

BrianCurtis-NOAA removed the cheyenne-gnu-RT label May 10, 2021

RT JOBS PASSED: cheyenne.gnu. Log file uploaded.

82f56f4

on-behalf-of @ufs-community

MinsukJi-NOAA added the jet-intel-RT label May 11, 2021

BrianCurtis-NOAA removed the jet-intel-RT label May 11, 2021

chan-hoo added 2 commits May 11, 2021 12:17

RT jobs passed: wcoss_dell_p3, wcoss_cray

593d9de

Merge remote-tracking branch 'origin/feature/ic_string' into feature/…

5d934ae

…ic_string

Add orion RT log; run-ci

38ed998

junwang-noaa approved these changes May 12, 2021

View reviewed changes

MinsukJi-NOAA added the jet-intel-RT label May 12, 2021

BrianCurtis-NOAA removed the jet-intel-RT label May 12, 2021

Add Jet log; run-ci

37ba8bd

MinsukJi-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label May 12, 2021

chan-hoo added 2 commits May 12, 2021 13:25

Update FV3 and gitmodules

07fc441

Merge remote-tracking branch 'origin/feature/ic_string' into feature/…

89c553b

…ic_string

climbfuji requested changes May 12, 2021

View reviewed changes

climbfuji approved these changes May 12, 2021

View reviewed changes

Point to the correct FV3 hash

2bc4399

climbfuji merged commit 2f1c8e1 into ufs-community:develop May 12, 2021

chan-hoo deleted the feature/ic_string branch May 12, 2021 15:15

junwang-noaa mentioned this pull request Jun 23, 2021

Feature/gsl develop diagnostics 20210609 #660

Merged

14 tasks

JeffBeck-NOAA mentioned this pull request Jun 29, 2021

Code change for RRFS application NOAA-GSL/UFS_UTILS#4

Closed

epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023

Add the pazi parameter option to the creation of the regional_esg_gri…

b8bc6cf

…d namelist; set pazi=-13.0 for the RRFS_NA_3km domain (#567)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'netcdf' and 'grib2' to IC input source options in regional IC/LBC routines (re-opened) #567

Add 'netcdf' and 'grib2' to IC input source options in regional IC/LBC routines (re-opened) #567

chan-hoo commented May 10, 2021 •

edited by MinsukJi-NOAA

Loading

MinsukJi-NOAA commented May 10, 2021

BrianCurtis-NOAA commented May 11, 2021

BrianCurtis-NOAA commented May 11, 2021

DeniseWorthen commented May 11, 2021

MinsukJi-NOAA commented May 11, 2021

DeniseWorthen commented May 11, 2021

MinsukJi-NOAA commented May 12, 2021

junwang-noaa commented May 12, 2021 via email

MinsukJi-NOAA commented May 12, 2021

climbfuji left a comment

MinsukJi-NOAA commented May 12, 2021

climbfuji left a comment

MinsukJi-NOAA commented May 12, 2021 •

edited

Loading

junwang-noaa commented May 12, 2021

Add 'netcdf' and 'grib2' to IC input source options in regional IC/LBC routines (re-opened) #567

Add 'netcdf' and 'grib2' to IC input source options in regional IC/LBC routines (re-opened) #567

Conversation

chan-hoo commented May 10, 2021 • edited by MinsukJi-NOAA Loading

Description

Issue(s) addressed

Testing

Dependencies

Contributors

MinsukJi-NOAA commented May 10, 2021

BrianCurtis-NOAA commented May 11, 2021

BrianCurtis-NOAA commented May 11, 2021

DeniseWorthen commented May 11, 2021

MinsukJi-NOAA commented May 11, 2021

DeniseWorthen commented May 11, 2021

MinsukJi-NOAA commented May 12, 2021

junwang-noaa commented May 12, 2021 via email

MinsukJi-NOAA commented May 12, 2021

climbfuji left a comment

Choose a reason for hiding this comment

MinsukJi-NOAA commented May 12, 2021

climbfuji left a comment

Choose a reason for hiding this comment

MinsukJi-NOAA commented May 12, 2021 • edited Loading

junwang-noaa commented May 12, 2021

chan-hoo commented May 10, 2021 •

edited by MinsukJi-NOAA

Loading

MinsukJi-NOAA commented May 12, 2021 •

edited

Loading