Code change for RRFS application #4
Conversation
hu5970
commented
Jun 29, 2021
hu5970
commented
vegetation fraction, vegmax, vegmin, and LAI.
Improve input to correctly read operational HRRR/RAP.
… and vegetation type from input data. Addresses Issue ufs-community#246.
Cherry-pick of authoritative UFS_UTILS PR#247 that went into the release/public-v2 branch
Change grib2 string to FV3GFS NEMSIO for ICs and LBCs.
1) Add more options in the input for reading ice mxing ratio, vegetation fraction, vegmax, vegmin, and LAI 2) Change grib2 string to FV3GFS NEMSIO for ICs and LBCs
Sync with EMC UFS_UTIL develop branch
Sync with hu5970 Feature/rrfs
…difference between two branch. RRFS_dev_debug includes some code from GSL RRFS_dev. Those code differences are only for soil type and need to be investigated in the code merge with EMC develop.
Manually merge feature/rrfs on top of the RRFS_dev_debug
sorc/chgres_cube.fd/write_data.F90
Outdated
| @@ -538,7 +538,7 @@ subroutine write_fv3_atm_bndy_data_netcdf(localpet) | |||
| elseif (trim(input_type) == "gaussian_netcdf") then | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@JeffBeck-NOAA Yes, I can test if this one is still needed or not because you did mentioned this is not required in new code base. Any other code we need to change. I can update the code and then test it in dev2, which is using grib2 files from GFS.
There was a problem hiding this comment.
OK, that sounds good. I think the only change we needed was related to the grib2 fields that is in this PR. @LarissaReames-NOAA is working on implementing the grib2 field fix in the authoritative repo, and a PR will likely be opened soon.
|
This PR should not be going into develop. |
…ed it: Change grib2 string to FV3GFS NEMSIO for ICs and LBCs
|
@JeffBeck-NOAA I have confirmed that we don't need the follow change anymore: Change grib2 string to FV3GFS NEMSIO for ICs and LBCs Now the question is " should we make a PR to NOAA-EMC/UFS_UTIL develop branch"? |
|
@hu5970, thanks for confirming the string issue. Since the default in the develop branch of the authoritative UFS_UTILS uses the GRIB2 string, there's actually nothing that we need to do to fix the problem there. It's all be handled in ufs-weather-model. For the GRIB2 soil fields, @LarissaReames-NOAA is working on a version of your modifications to open a PR into the authoritative develop branch and will have that PR ready soon. Do we know what the source of the soil moisture problem is? |
|
@JeffBeck-NOAA We don't know what caused the soil moisture problem. After merged RRFS_dev with the EMC develop, the soil moisture problem was gone. Now, do you have an idea how to finalize the soil type process for NO Climate option? That is the only difference between RRFS_dev and EMC develop. Thanks, |
|
@hu5970, are you referring to the problems with land points? If so, that was fixed by @LarissaReames-NOAA in the authoritative NOAA-EMC/UFS_UTILS develop branch. See this PR. Since you merged the latest develop into the RRFS_dev branch, then we have this fix. |
|
I'm closing this PR since it is open on the wrong branch. |
