Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mesh cap #1366

Merged
merged 20 commits into from
Sep 19, 2022
Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Aug 12, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Updates the WW3 mesh cap to add desired features. This PR does not implement those features (e.g. using a nml file instead of the inp file for WW3 or utilizing gridded netCDF output) but could be added if desired.

Issue(s) addressed

Testing

All baselines on hera.intel and hera.gnu were B4B at 1bed727. Tests were repeated at 24eb369 and again passed for both hera.intel and hera.gnu.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@DeniseWorthen DeniseWorthen marked this pull request as ready for review September 8, 2022 12:56
@DeniseWorthen DeniseWorthen mentioned this pull request Sep 8, 2022
16 tasks
@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Sep 8, 2022
@DeniseWorthen DeniseWorthen linked an issue Sep 8, 2022 that may be closed by this pull request
DeniseWorthen and others added 2 commits September 13, 2022 16:13
* restored files with trailing whitespace and restored
implicit none to non-module level default by request of CM
@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA @MatthewMasarik-NOAA aqm #1405 is ready. We can reschedule this pr after #1405. What do you think?

@JessicaMeixner-NOAA
Copy link
Collaborator

It's my understanding that the AQM has operational needs to get in ASAP, so that sounds okay to me.

@jkbk2004
Copy link
Collaborator

It's my understanding that the AQM has operational needs to get in ASAP, so that sounds okay to me.

Thanks! I will update commit table.

@jkbk2004
Copy link
Collaborator

We can work on this pr. I will start testing this afternoon.

on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1025354010/20220916233015/ufs-weather-model
Please make changes and add the following label back: jet-intel-RT

on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
[RT] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/1025354010/20220916233006/ufs-weather-model
[RT] Error: Test cpld_2threads_p8 003 failed in run_test failed
[RT] Error: Test control_restart_p8 043 failed in run_test failed
[RT] Error: Test regional_netcdf_parallel 052 failed in run_test failed
[RT] Error: Test regional_3km_decomp 054 failed in run_test failed
[RT] Error: Test rap_control 055 failed in run_test failed
[RT] Error: Test rap_sfcdiff 061 failed in run_test failed
[RT] Error: Test rap_sfcdiff_decomp 062 failed in run_test failed
[RT] Error: Test hrrr_control_2threads 066 failed in run_test failed
[RT] Error: Test rrfs_v1nssl 069 failed in run_test failed
[RT] Error: Test rrfs_v1nssl_nohailnoccn 070 failed in run_test failed
[RT] Error: Test rrfs_conus13km_hrrr_warm 071 failed in run_test failed
[RT] Error: Test rrfs_conus13km_radar_tten_warm 072 failed in run_test failed
[RT] Error: Test control_csawmgt 074 failed in run_test failed
[RT] Error: Test hafs_regional_specified_moving_1nest_atm 125 failed in run_test failed
Please make changes and add the following label back: gaea-intel-RT

@jkbk2004
Copy link
Collaborator

slurm issue on jet and gaea: jobs ran ok with resubmission

@BrianCurtis-NOAA
Copy link
Collaborator

@DeniseWorthen You can work on merging WW3. All RT's passed.

@JessicaMeixner-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA @DeniseWorthen WW3 submodule has been merged.

Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash's all good.

@jkbk2004 jkbk2004 merged commit 52072c5 into ufs-community:develop Sep 19, 2022
@DeniseWorthen DeniseWorthen deleted the feature/meshcap_update branch January 30, 2023 20:30
@DeniseWorthen DeniseWorthen self-assigned this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update WW3 meshcap for recent development Unstructured meshes and domain decomposition using WW3 mesh cap
4 participants