Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh cap update #780

Conversation

DeniseWorthen
Copy link
Contributor

Pull Request Summary

Update mesh cap with changes needed for eventual merge to develop.

Description

  • Allows users of the mesh cap to set runtime options for custom restart and history file names and to create netcdf output for gridded fields at run time. For UWM, these can be set in the nems.configure using the settings
  gridded_netcdfout = true
  user_sets_histname = true
  user_sets_restname = true

History file names will then be casename.ww3.hi.YYYY-MM-DD-SSSS.nc and casename.ww3.r.YYYY-MM-DD-SSSS where casename is set from nems.configure for each application (e.g ufs.hafs)

  • Replaces previous set_shel_inp and read_shel_inp routines with the applicable section from ww3_shel.F90 to read either a inp or nml file. When used in UFS, the only required fields in the nml file are the list of forcing fields, the desired output fields, the name of the points file (if desired) and the stride for history and restart files. For example,
&input_nml
  input%forcing%winds = 'C'
  input%forcing%currents  = 'F'
  input%forcing%ice_conc  = 'F'
/
&output_type_nml
  type%field%list     = 'WND HS FP DP PHS PTP PDIR'
  type%point%file     = 'points.list'
/

&output_date_nml
  date%field%outffile  = '1'
  date%field%stride    = '3600'
  date%point%stride    = '3600'
  date%restart2%stride = '3600'
/
  • Removes wav_tauice fields which are unused when coupling WW3 to CICE6.

Issue(s) addressed

Commit Message

Update mesh cap for custom user filenames, netcdf gridded output and logical control of some ifdef options.

co-authors : @mvertens

Testing

All UFS-WM baselines were run using hera.intel and hera.gnu and were B4B.

JessicaMeixner-NOAA and others added 30 commits August 27, 2021 17:10
…ixner-NOAA/WW3 into feature/switch2cpp_build_nosrc
DeniseWorthen and others added 14 commits August 29, 2022 12:55
…/meshcap_update_unified2

* fix CMakelist, remove print messages in w3inint and fix flag
in w3wavemd
* langmt  in w3init fixed
* remove "uwm" from output control in w3wave; works only if stride
is set <= history_n. output control for uwm will remain with the
native stride setting
* add missing convert_endian to file open
* white space changes
* remove logging messages from wav_shel_inp
* fix broadcast of initfile for cesm
* fix w3wavemd for output for cesm using histwr and uwm using
native strides
* whitespace
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standalone WW3 regression tests should be finishing soon. These tests will help ensure there are no unintended impacts in the updates in w3wave (which visually all look good so far).

For issue #679 @MatthewMasarik-NOAA and I will work to extend the work here to remove duplicated code and have ww3_shel exes use the same separated subroutine for reading ww3_shel.inp. This issue will remain open after this PR.

For issue #674 I will be working as I mentioned the other day to extend this work so that the restart file writing will be variables read in from WW3 input files. This will either change the reading form the nems.configure or allow for the nems.configure to over-ride this. This issue will remain open after this PR.

For issue issue #673 Work will be ongoing to extend this capability to reach the desired capabilities mentioned in the issues.

I do believe this PR will close issue #678 which was not mentioned in the PR.

I will report on the standalone WW3 regression tests as soon as the script has finished running, but wanted to provide this update now. Apologies for the delay in review, we'll be working to reduce the review time for PRs in the future and thank you so much for the work you have contributed here!

@@ -0,0 +1,1201 @@
!> @file wav_shr_flags
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems related to if-def removals and not this PR, but perhaps I've missed something? Is this file necessary for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need all the flags, but it was simply easier to keep the original list together.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we backed out the W3_SBS change, can all of this be backed out?

@JessicaMeixner-NOAA
Copy link
Collaborator

The WW3 standalone tests performed as expected.

@JessicaMeixner-NOAA
Copy link
Collaborator

@DeniseWorthen I really appreciate your updates to this branch. I'll be re-running the standalone WW3 regression tests but expect no issues there.

@DeniseWorthen
Copy link
Contributor Author

@JessicaMeixner-NOAA @MatthewMasarik-NOAA I had fixed the CI previously for the ufs branch but it is now failing. So I checked out develop and pushed a copy to my fork and it also fails. I don't know why---can one of you figure it out? The branch I created and tested is testci. You can see the workflow error in the Intel Linux Build / setup (push)

Note that versions of Spack older than 0.19 may not be able to use the updated configuration.
==> Error: list index out of range
Error: Process completed with exit code 3.

@JessicaMeixner-NOAA
Copy link
Collaborator

@DeniseWorthen yes, we can look at the ci for this branch and develop. Realistically, we will not be able to get it fixed before this branch's turn in the ufs-queue.

@JessicaMeixner-NOAA
Copy link
Collaborator

Results of standalone regression tests were as expected.

Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates were made based on review and ufs-waether-model regression tests passed (ufs-community/ufs-weather-model#1366) in addition to ww3 standalone.

Thanks @DeniseWorthen !

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 7e692b6 into NOAA-EMC:dev/ufs-weather-model Sep 19, 2022
@DeniseWorthen DeniseWorthen deleted the feature/meshcap_stripped branch November 3, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants