Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the build and gdas_init scripts to S4 #557

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

DavidHuber-NOAA
Copy link
Collaborator

Support for S4 has been added to the build scripts to support the global workflow. Additionally, a partial driver for gdas_init (chgres only) has been written for S4. The port is supported by an official build of hpc-stack supported by me on the system. I have run several test cycles, the logs of which are available on Orion (/work/noaa/nesdis-rdo2/dhuber/s4_logs/test_dev). I've also run a test case of gdas_init for 2019111818 @192/96, comparing the resulting outputs from S4 and Hera, which were bitwise identical. Please let me know if you need any further tests completed.

Fixes #543

@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidHuber-NOAA I will look at your log files on Orion. Unfortunately, I don't have access to S4. I will also test your branch on Orion, Jet, Hera, WCOSS-cray and WCOSS-dell to ensure your changes do not affect those machines. After a quick look at what your changes, I don't expect problems.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-requested a review August 9, 2021 13:59
@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Can you open up the unix permissions on the sub-directories in /work/noaa/nesdis-rdo2/dhuber

@DavidHuber-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA Done.

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA Done.

Thanks. I looked at the log files from one cycle. The global_cycle steps ran without any error. That is the only ufs_utils program run by the global workflow.

@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Thanks for testing the gdas_init utility. Bit identical results is a good thing.

@GeorgeGayno-NOAA
Copy link
Collaborator

The branch at c707758 was successfully compiled on all Tier 1 machines - Orion, Jet, Hera, WCOSS-Cray and WCOSS-Dell. And all consistency tests passed.

@GeorgeGayno-NOAA
Copy link
Collaborator

@DavidHuber-NOAA We will accept this PR and future S4-related updates. But since S4 is not an official Tier 1 machine, we can't test all future changes to ensure they won't break S4. Just a heads up.

@DavidHuber-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA Understood, thank you for the heads up.

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 6b1d621 into ufs-community:develop Aug 9, 2021
@GeorgeGayno-NOAA
Copy link
Collaborator

@KateFriedman-NOAA FYI.

@KateFriedman-NOAA
Copy link
Collaborator

@KateFriedman-NOAA FYI.

Thanks @GeorgeGayno-NOAA and @DavidHuber-NOAA !

@DavidHuber-NOAA DavidHuber-NOAA deleted the port_2_s4 branch August 9, 2021 18:42
LarissaReames-NOAA added a commit to LarissaReames-NOAA/UFS_UTILS that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port UFS_UTILS to S4
3 participants