Chore/python3 #23
Merged
Chore/python3 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulineribeyre
force-pushed
the
chore/python3
branch
from
7a54647 to
21b8d49
Compare
paulineribeyre
force-pushed
the
chore/python3
branch
from
21b8d49 to
66f394e
Compare
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Avantol13
requested changes
Jul 2, 2019
setup.py
Outdated
| "jmespath==0.9.2", | ||
| "pbr==2.0.0", | ||
| "cdislogging", | ||
| "gen3cirrus>=0.3.0,<1.0.0", |
There was a problem hiding this comment.
make sure you update this to compatible cirrus
test.py
Outdated
| @@ -0,0 +1,63 @@ | |||
| d = values = { | |||
There was a problem hiding this comment.
is this file supposed to be here? :P
Avantol13
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testinstead of selected files - one test suite that was NOT included in the tests before is broken, did not fix itTODO:
Breaking Changes
Dependency updates