Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/python3 #22

Merged
merged 4 commits into from
Jul 2, 2019
Merged

Chore/python3 #22

merged 4 commits into from
Jul 2, 2019

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Jun 26, 2019 •
edited
Loading

  • ran 2to3 for python 2 to 3 syntax updates
  • ran black and added wool
  • query parameters in URLs are not sorted in the same order in py3 as in py2: fix the tests to not rely on param order

Breaking Changes

  • Python 3 instead of python 2

This was referenced Jun 26, 2019
Closed
Merged
@paulineribeyre paulineribeyre force-pushed the chore/python3 branch 2 times, most recently from c016435 to f78f563 Compare June 28, 2019 16:54
@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre paulineribeyre merged commit bdfdeb0 into master Jul 2, 2019
@paulineribeyre paulineribeyre deleted the chore/python3 branch July 2, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avantol13 Avantol13 Avantol13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @Avantol13