Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-9192 Validate format #363

Merged
merged 4 commits into from
Jan 14, 2022
Merged

PXP-9192 Validate format #363

merged 4 commits into from
Jan 14, 2022

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Dec 21, 2021 •
edited
Loading

Jira Ticket: PXP-9192

requires uc-cdis/gen3datamodel#35

New Features

  • Validate jsonschema format during submission

Breaking Changes

  • Sheepdog now validates formats. If your dictionary uses formats and you have existing data or submission pipelines that do not respect these formats, this might be a breaking change

Dependency updates

  • gen3datamodel to 3.1.0

@PlanXCyborg
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre paulineribeyre mentioned this pull request Dec 22, 2021
Merged
paulineribeyre
paulineribeyre commented Dec 22, 2021
View reviewed changes
requirements.txt
@@ -27,7 +27,6 @@ xmltodict==0.9.2
more-itertools==5.0.0
cdis_oauth2client==1.0.0
cdispyutils==1.0.4
datamodelutils==1.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed duplicate (it's also on line 5)

@paulineribeyre paulineribeyre mentioned this pull request Jan 11, 2022
Merged
nss10
nss10 previously approved these changes Jan 11, 2022
View reviewed changes
@nss10 nss10 self-requested a review January 14, 2022 22:58
nss10
nss10 approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@nss10 nss10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulineribeyre
Copy link
Contributor Author

Snyk failure is a false positive - we can use strict-rfc3339, which is under a GPL-3.0 license

@paulineribeyre paulineribeyre merged commit 12d4373 into master Jan 14, 2022
@paulineribeyre paulineribeyre deleted the fix/format branch January 14, 2022 23:03
This was referenced Mar 7, 2022
Merged
Merged
Closed
Merged
This was referenced Mar 9, 2022
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 21, 2022
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 29, 2022
Closed
Closed
This was referenced Apr 30, 2022
Closed
Closed
Closed
This was referenced Jun 23, 2022
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jul 21, 2022
Open
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 14, 2022
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
This was referenced Dec 18, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nss10 nss10 nss10 approved these changes

@johnfrancismccann johnfrancismccann johnfrancismccann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulineribeyre @PlanXCyborg @nss10 @johnfrancismccann