Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy multiple paymodels branches to BRH #4297

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Deploy multiple paymodels branches to BRH #4297

merged 3 commits into from
Mar 10, 2022

Conversation

jawadqur
Copy link
Contributor

  • Deploy latest versioin of services to BRH
  • Deploy multiple paymodel branches and config to BRH

@jawadqur jawadqur requested a review from mfshao March 10, 2022 16:05
@PlanXCyborg
Copy link
Contributor

brh.data-commons.org/manifest.json

⚠️ Services on branch

  • hatchery
  • portal

⚠️ Services are being downgraded

  • portal

Breaking changes

  • sheepdog
    • Sheepdog now validates formats. If your dictionary uses formats and you have existing data or submission pipelines that do not respect these formats, this might be a breaking change (PXP-9192 Validate format sheepdog#363)

@PlanXCyborg
Copy link
Contributor

brh.data-commons.org/manifest.json

⚠️ Services on branch

  • hatchery
  • portal

⚠️ Services are being downgraded

  • portal

Breaking changes

  • sheepdog
    • Sheepdog now validates formats. If your dictionary uses formats and you have existing data or submission pipelines that do not respect these formats, this might be a breaking change (PXP-9192 Validate format sheepdog#363)

mfshao
mfshao approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let wait for jenkins since the change in service versions is kind of large

@PlanXCyborg
Copy link
Contributor

brh.data-commons.org/manifest.json

⚠️ Services on branch

  • hatchery
  • portal

⚠️ Services are being downgraded

  • portal

Breaking changes

  • sheepdog
    • Sheepdog now validates formats. If your dictionary uses formats and you have existing data or submission pipelines that do not respect these formats, this might be a breaking change (PXP-9192 Validate format sheepdog#363)

@jawadqur
Copy link
Contributor Author

lgtm, let wait for jenkins since the change in service versions is kind of large

Thanks for fixing my typo, trying to fix another typo (haha 😭). I agree let's wait for Jenkins.

@mfshao
Copy link
Contributor

mfshao commented Mar 10, 2022

test failing because no sower, merging

@mfshao mfshao merged commit f64bdad into master Mar 10, 2022
@mfshao mfshao deleted the feat/brh_mp branch March 10, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
test-portal-discoveryPageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawadqur @PlanXCyborg @mfshao