Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/arborist #608

Merged
merged 71 commits into from
May 20, 2019
Merged

feat/arborist #608

merged 71 commits into from
May 20, 2019

Conversation

rudyardrichter
Copy link
Contributor

@rudyardrichter rudyardrichter commented Apr 5, 2019

New Features

  • Configure new clients with arborist policies using --arborist and --policies flags for fence-create
  • Use arborist for authorization checks on downloading data files from indexd, as long as the authz field is present in the index record

Breaking Changes

  • Users' RBAC policies are now owned by arborist, not fence, so the tables are removed from fence/userdatamodel.
  • The usersync is updated to work specifically with the new arborist version.
  • In general, this and following versions of fence should be deployed only with arborist>=2.0.0

@rudyardrichter rudyardrichter marked this pull request as ready for review May 14, 2019 19:51
@PlanXCyborg
Copy link
Contributor

PlanXCyborg commented May 14, 2019

This PR contains code that is not formatted correctly according to black. Run black on your code before merging.

Expand the full diff to see formatting changes
--- fence/__init__.py
+++ blackened
@@ -15,11 +15,11 @@
 from fence.oidc.server import server
 from fence.rbac.client import ArboristClient
 from fence.resources.aws.boto_manager import BotoManager
 from fence.resources.openid.google_oauth2 import GoogleOauth2Client as GoogleClient
 from fence.resources.openid.microsoft_oauth2 import (
-    MicrosoftOauth2Client as MicrosoftClient
+    MicrosoftOauth2Client as MicrosoftClient,
 )
 from fence.resources.openid.orcid_oauth2 import OrcidOauth2Client as ORCIDClient
 from fence.resources.storage import StorageManager
 from fence.resources.user.user_session import UserSessionInterface
 from fence.error_handler import get_error_response

This formatting comment was generated automatically by a script in uc-cdis/wool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants