feat(builtin-groups): support builtin groups in user.yaml #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Avantol13
reviewed
May 14, 2019
Avantol13
requested changes
May 14, 2019
| if response.status_code != 204: | ||
| msg = data.get("error", "unhelpful response from arborist") | ||
| if isinstance("error", dict): | ||
| msg = data["error"].get("message", msg) |
There was a problem hiding this comment.
do you need to check if "error" in data, or do non-204s always have that information?
There was a problem hiding this comment.
should always be there but never hurts 👍
Co-Authored-By: Alexander VanTol <Avantol13@users.noreply.github.com>
Avantol13
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
anonymousandlogged-ingroups in theuser.yaml.