-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PXP-6409 Remove arranger #743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request fixes 4 alerts when merging 6a1e3f6 into a6cea28 - view on LGTM.com fixed alerts:
|
ZakirG
approved these changes
Sep 28, 2020
This pull request fixes 4 alerts when merging 3827395 into 7b8324f - view on LGTM.com fixed alerts:
|
This pull request fixes 4 alerts when merging 202a176 into cffd906 - view on LGTM.com fixed alerts:
|
This pull request fixes 4 alerts when merging b8129ce into 08f94f1 - view on LGTM.com fixed alerts:
|
This was referenced Mar 11, 2021
This was referenced May 6, 2021
This was referenced Aug 20, 2021
This was referenced Sep 3, 2021
Merged
This was referenced Sep 13, 2021
This was referenced Sep 24, 2021
This was referenced Apr 1, 2022
Closed
This was referenced Dec 19, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fulfills https://ctds-planx.atlassian.net/browse/PXP-6409
Removing Arranger and related codes (mostly the old
DataExplorer
andExplorerPage
) to simplify logic and reduce bundle sizeDataExplorer
is the old Arranger based explorer, notGuppyDataExplorer
ExplorerPage
is the old Peregrine based file explorerClose #725
Breaking Changes
DataExplorer
is removedExplorerPage
is removedDependency updates
Deployment changes
dataExplorerConfig
field in its portal config has ONLYarrangerConfig
field but NOguppyConfig
field (it is okay to have both). If so, please updatedataExplorerConfig
to use Guppy