Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXP-6409 Remove arranger #743

Merged
merged 4 commits into from
Oct 5, 2020
Merged

PXP-6409 Remove arranger #743

merged 4 commits into from
Oct 5, 2020

Conversation

mfshao
Copy link
Collaborator

@mfshao mfshao commented Sep 25, 2020

This PR fulfills https://ctds-planx.atlassian.net/browse/PXP-6409

Removing Arranger and related codes (mostly the old DataExplorer and ExplorerPage) to simplify logic and reduce bundle size

  • DataExplorer is the old Arranger based explorer, not GuppyDataExplorer
  • ExplorerPage is the old Peregrine based file explorer

Close #725

Breaking Changes

  • Arranger is removed
  • DataExplorer is removed
  • ExplorerPage is removed

Dependency updates

  • Arranger is removed

Deployment changes

  • All envs should check if the dataExplorerConfig field in its portal config has ONLY arrangerConfig field but NO guppyConfig field (it is okay to have both). If so, please update dataExplorerConfig to use Guppy

@lgtm-com
Copy link

lgtm-com bot commented Sep 25, 2020

This pull request fixes 4 alerts when merging 6a1e3f6 into a6cea28 - view on LGTM.com

fixed alerts:

  • 2 for Potentially inconsistent state update
  • 1 for Useless assignment to local variable
  • 1 for Unused or undefined state property

@mfshao mfshao changed the title [WIP]remove arranger PXP-6409 Remove arranger Sep 28, 2020
@mfshao mfshao marked this pull request as ready for review September 28, 2020 22:00
@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2020

This pull request fixes 4 alerts when merging 3827395 into 7b8324f - view on LGTM.com

fixed alerts:

  • 2 for Potentially inconsistent state update
  • 1 for Useless assignment to local variable
  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented Sep 30, 2020

This pull request fixes 4 alerts when merging 202a176 into cffd906 - view on LGTM.com

fixed alerts:

  • 2 for Potentially inconsistent state update
  • 1 for Useless assignment to local variable
  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented Oct 5, 2020

This pull request fixes 4 alerts when merging b8129ce into 08f94f1 - view on LGTM.com

fixed alerts:

  • 2 for Potentially inconsistent state update
  • 1 for Useless assignment to local variable
  • 1 for Unused or undefined state property

@mfshao mfshao merged commit 63e87dd into master Oct 5, 2020
@mfshao mfshao deleted the chore/no-arranger branch October 5, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants