Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/batch export #1708

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Feat/batch export #1708

merged 1 commit into from
Aug 13, 2021

Conversation

mcannalte
Copy link
Contributor

@mcannalte mcannalte commented Aug 12, 2021

This is part of a set of PRs for direct downloads, see design doc for further info (https://docs.google.com/document/d/1fWhN1eDnBRF1ueEP_p5kjEhw7RKzYykqOeVh0tKO4kc/edit)

New Features

  • When sower config contains the "batch-export" job, set up s3 buckets + secrets to support this job

@@ -273,6 +273,12 @@ else
gen3_log_info "not deploying ws-storage - no manifest entry for '.versions[\"ws-storage\"]'"
fi

if g3k_manifest_lookup '.sower[] | select( .name=="batch-export" )' 2> /dev/null; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 Did not know this existed! Very cool

@mcannalte mcannalte marked this pull request as ready for review August 12, 2021 16:21
@mcannalte mcannalte requested review from ZakirG and mfshao August 13, 2021 15:23
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay to me, but would like if some devops can r it since it is a cloud-auto PR

@mcannalte mcannalte requested a review from jawadqur August 13, 2021 20:58
@mcannalte mcannalte merged commit 83be0bb into master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants