Upload program debug databases #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stored inside ${{ env.workDir }}/debug-database-${{ matrix.AppID }}/
Always runs.
Inside ${{ env.workDir }}/debug-database-${{ matrix.AppID }}/
Same retention policy as the appx.
CarlosNihelton
force-pushed
the
ci-pdbs-deeng-349
branch
from
fe2326b to
b5dad8f
Compare
CarlosNihelton
force-pushed
the
ci-pdbs-deeng-349
branch
from
bb3c4f2 to
5764df3
Compare
Achieves that by separating it from the other build artifacts.
CarlosNihelton
changed the title
toktamis
reviewed
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of the current practices of:
build-wslCI workflow andThe proposed set of changes allows collecting program database files (.PDB) generated during compilation of the binaries bundled in the appx for easier crash analysis in the future.
PDBs are collected for each app built, always, and stored with a short retention policy (the same applied to the appx stored as part of the CI). Whenever those builds are pushed to the MS Store, their PDB's also go to the repository wiki as compressed tar balls, with the intent of allowing retrieving from the wiki the always up-to-date set of PDB's.
Later, during a release, we can take those artifacts from the wiki and upload them as assets for longer retention.
This run successfullty collected the PDB files and uploaded them together with the appx, as well as the wiki. After that I changed the part that pushes to the wiki to be skipped if there was no upload to the store. This run is the most updated, skipping the wiki part.
In order to certify that the PDB's are realy inside the wiki, one can
git clone https://github.com/ubuntu/WSL.wiki.gitand check the contents of thedebug-databasesdirectory. It should contain one tarball per Ubuntu app from which we collected PDBs during build. Those tarballs won't show up in GitHub website, since they are not text files.We need to merge ubuntu/ubuntu-wsl-splash#27 (and refresh the submodule of course) in order to see the PDB's from the ubuntu-wsl-splash Flutter app. We should also push a new version of Ubuntu 22.04 whenever all those changes are in
mainin order to have a collection of PDB's matching the exact compilation of the app pushed to the store.