Selection of default upgrade policy #239
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
DistroLauncher/upgrade_policy.cpp
Outdated
| const fs::path log{L"/var/log/upgrade-policy-changed.log"}; | ||
| const fs::path policyfile{L"/etc/update-manager/release-upgrades"}; | ||
|
|
||
| if (fs::exists(Oobe::WindowsPath(log))) { |
There was a problem hiding this comment.
Since this line will run on every launch, it is subject to user configuration preventing Windows from being able to execute the filesystem calls, thus throwing filesystem exceptions. You may want to consider calling the std::error_code overload to avoid such behavior.
Now we raise a subsequent question; what to do on error? If we cannot assess whether the log exists or not through the filesystem API what should we do? We can fallback to test with a Linux command, like if (WslLaunchSuccess(L"ls $log")).
There was a problem hiding this comment.
Agree on the fallback mechanism. I used test -f $log.
| void SetDefaultUpgradePolicy() | ||
| { | ||
| auto mutex = NamedMutex(L"upgrade-policy"); | ||
| mutex.lock().and_then(internal::SetDefaultUpgradePolicyImpl); |
There was a problem hiding this comment.
An alternative to my previous comment about filesystem exceptions might be setting a reasonable or_else function here. But that seems more complicated, unless you don't want to proceed in case of filesystem errors.
There was a problem hiding this comment.
Beware that or_else is called when we fail to switch user to root.
Throwing an exception during and_then will only revert the user to default and rethrow again; it will not call or_else.
I think the best is to have a fallback.
|
I merged, because I'll need one function you've implemented here. |
This PR is a temporary solution to #226.