Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): sidebar journal panel template onboarding and setting #9680

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jan 14, 2025

close AF-2108

Copy link
Member Author

CatsJuice commented Jan 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CatsJuice CatsJuice marked this pull request as ready for review January 14, 2025 08:06
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-sidebar-journal-panel branch from 159ff1a to 809e8ea Compare January 15, 2025 01:53
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-sidebar-entrance branch from 0c3d6b6 to c3166ef Compare January 15, 2025 02:18
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-sidebar-journal-panel branch from 809e8ea to 1ae7cce Compare January 15, 2025 02:18
@CatsJuice CatsJuice changed the base branch from catsjuice/feat/template-sidebar-entrance to graphite-base/9680 January 15, 2025 03:45
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-sidebar-journal-panel branch from 1ae7cce to d9b5a12 Compare January 15, 2025 04:03
@CatsJuice CatsJuice changed the base branch from graphite-base/9680 to canary January 15, 2025 04:04
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-sidebar-journal-panel branch from d9b5a12 to c5f6973 Compare January 15, 2025 04:04
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.85%. Comparing base (0b2d11e) to head (d82951a).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9680      +/-   ##
==========================================
- Coverage   52.86%   52.85%   -0.01%     
==========================================
  Files        2194     2194              
  Lines       98830    98830              
  Branches    16807    16807              
==========================================
- Hits        52243    52241       -2     
- Misses      44779    45151     +372     
+ Partials     1808     1438     -370     
Flag Coverage Δ
server-test 78.03% <ø> (ø)
unittest 32.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 15, 2025

Merge activity

  • Jan 15, 4:21 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 15, 4:43 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Lint', 'E2E Test (1)', 'E2E Test (2)', 'E2E Test (3)', 'E2E Test (4)', 'E2E Test (5)', 'E2E Mobile Test (1)', 'E2E Mobile Test (2)', 'E2E Mobile Test (3)', 'E2E Mobile Test (4)', 'E2E Mobile Test (5)', 'Build @affine/electron renderer', 'test-build-mobile-app / build-ios-web', 'test-build-mobile-app / build-android-web', 'Server E2E Test 1/3', 'Server E2E Test 2/3', 'Server E2E Test 3/3', 'Server Desktop E2E Test').
  • Jan 15, 6:21 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 15, 6:40 AM EST: A user merged this pull request with the Graphite merge queue.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-sidebar-journal-panel branch from c5f6973 to 75034ee Compare January 15, 2025 09:22
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-sidebar-journal-panel branch from 8509f05 to d82951a Compare January 15, 2025 11:21
@graphite-app graphite-app bot merged commit d82951a into canary Jan 15, 2025
61 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/template-sidebar-journal-panel branch January 15, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants