Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): template doc list empty ui #9675

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Jan 14, 2025

close AF-2109

Copy link
Member Author

CatsJuice commented Jan 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CatsJuice CatsJuice marked this pull request as ready for review January 14, 2025 02:27
Base automatically changed from catsjuice/feat/template-doc-setting-ui to canary January 14, 2025 02:41
@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-list-empty branch from f9d9895 to 1e18f5f Compare January 15, 2025 02:17
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (ff295f3) to head (1c90747).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...c/modules/template-doc/view/template-list-menu.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9675      +/-   ##
==========================================
+ Coverage   52.83%   52.86%   +0.03%     
==========================================
  Files        2199     2199              
  Lines       98894    98898       +4     
  Branches    16834    16835       +1     
==========================================
+ Hits        52247    52283      +36     
+ Misses      45209    45172      -37     
- Partials     1438     1443       +5     
Flag Coverage Δ
server-test 78.03% <ø> (ø)
unittest 32.21% <25.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 15, 2025

Merge activity

@CatsJuice CatsJuice force-pushed the catsjuice/feat/template-list-empty branch from 1e18f5f to 1c90747 Compare January 15, 2025 03:45
@graphite-app graphite-app bot merged commit 1c90747 into canary Jan 15, 2025
61 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/template-list-empty branch January 15, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants