Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: focus the create page item when query returns no result in at menu #10060

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 10, 2025

fix AF-2191

@pengx17 pengx17 marked this pull request as ready for review February 10, 2025 10:24
@pengx17 pengx17 requested a review from a team as a code owner February 10, 2025 10:24
Copy link
Collaborator Author

pengx17 commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added test Related to test cases app:core labels Feb 10, 2025
@graphite-app graphite-app bot requested review from a team February 10, 2025 10:24
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 53.67%. Comparing base (f774868) to head (fd25cd8).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...oot-block/widgets/linked-doc/linked-doc-popover.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10060      +/-   ##
==========================================
- Coverage   53.69%   53.67%   -0.02%     
==========================================
  Files        2285     2285              
  Lines      104621   104634      +13     
  Branches    17409    17410       +1     
==========================================
- Hits        56172    56162      -10     
- Misses      47084    47105      +21     
- Partials     1365     1367       +2     
Flag Coverage Δ
server-test 78.14% <ø> (-0.02%) ⬇️
unittest 31.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from xp/02-10-fix_at_menu_toolip_should_always_use_the_default_color to canary February 10, 2025 10:39
@pengx17 pengx17 force-pushed the xp/02-10-feat_focus_the_create_page_item_when_query_returns_no_result_in_at_menu branch from dc06577 to 6a886e3 Compare February 10, 2025 13:37
Copy link

graphite-app bot commented Feb 10, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the xp/02-10-feat_focus_the_create_page_item_when_query_returns_no_result_in_at_menu branch from 6a886e3 to fd25cd8 Compare February 10, 2025 15:52
@graphite-app graphite-app bot merged commit fd25cd8 into canary Feb 10, 2025
64 checks passed
@graphite-app graphite-app bot deleted the xp/02-10-feat_focus_the_create_page_item_when_query_returns_no_result_in_at_menu branch February 10, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants