Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: at menu toolip should always use the default color #10054

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 10, 2025

fix AF-2194

@pengx17 pengx17 marked this pull request as ready for review February 10, 2025 09:02
Copy link
Collaborator Author

pengx17 commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 requested a review from a team as a code owner February 10, 2025 09:02
@graphite-app graphite-app bot requested review from a team February 10, 2025 09:02
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.79%. Comparing base (0757f29) to head (6839e63).
Report is 2 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10054      +/-   ##
==========================================
- Coverage   53.80%   53.79%   -0.01%     
==========================================
  Files        2281     2281              
  Lines      104376   104376              
  Branches    17349    17345       -4     
==========================================
- Hits        56156    56147       -9     
- Misses      46854    46863       +9     
  Partials     1366     1366              
Flag Coverage Δ
server-test 78.13% <ø> (ø)
unittest 31.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 10, 2025

Merge activity

  • Feb 10, 4:18 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 4:40 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Legacy Blocksuite E2E Test (5)').
  • Feb 10, 4:54 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 5:39 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the xp/02-10-fix_at_menu_toolip_should_always_use_the_default_color branch from d8fdd53 to 4644406 Compare February 10, 2025 09:19
@pengx17 pengx17 force-pushed the xp/02-10-fix_at_menu_toolip_should_always_use_the_default_color branch from 4644406 to 6839e63 Compare February 10, 2025 10:24
@graphite-app graphite-app bot merged commit 6839e63 into canary Feb 10, 2025
64 checks passed
@graphite-app graphite-app bot deleted the xp/02-10-fix_at_menu_toolip_should_always_use_the_default_color branch February 10, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants