Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VIcon): fixes accessibility issue #5

Open
wants to merge 237 commits into
base: master
Choose a base branch
from
Open

Conversation

tmasrat
Copy link
Owner

@tmasrat tmasrat commented Dec 7, 2023

Description

If an icon is clickable, keyboard navigation to the icon should be allowed. If onClick is defined, I am setting the tabindex to 0
resolves vuetifyjs#18482

Markup:

<template>
  <v-app>
    <v-container>
      <v-select
          clearable
          label="Select"
          :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
      ></v-select>
    </v-container>
  </v-app>
</template>

@tmasrat tmasrat force-pushed the VIcon-accessibility branch from a363828 to 837aad9 Compare January 25, 2024 15:16
johnleider and others added 29 commits January 25, 2024 19:42
causes weird glitch where v-ripple__container eats
click events and prevents onClick from firing
remove template defined callback function
johnleider and others added 27 commits March 25, 2024 19:38
fixes vuetifyjs#18228

Co-authored-by: John Leider <john@vuetifyjs.com>
fixes vuetifyjs#19379

Co-authored-by: Son Tran <stt@cct-technology.com>
closes vuetifyjs#13516

Co-authored-by: John Leider <john@vuetifyjs.com>
@johnleider johnleider force-pushed the VIcon-accessibility branch from d758ead to 0759ba4 Compare March 28, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.3.21] Accessibility: v-select and v-autocomplete Clearable icon not keyboard accessible