forked from vuetifyjs/vuetify
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VIcon): fixes accessibility issue #5
Open
tmasrat
wants to merge
237
commits into
master
Choose a base branch
from
VIcon-accessibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a363828
to
837aad9
Compare
causes weird glitch where v-ripple__container eats click events and prevents onClick from firing
remove template defined callback function
fixes vuetifyjs#19087 closes vuetifyjs#19116 reverts 0a64f7f
This reverts commit 48906bd. closes vuetifyjs#19144
confirmed with slim & nav prop usage
It's the same thing that VBtn does
fixes vuetifyjs#18228 Co-authored-by: John Leider <john@vuetifyjs.com>
fixes vuetifyjs#19379 Co-authored-by: Son Tran <stt@cct-technology.com>
closes vuetifyjs#13516 Co-authored-by: John Leider <john@vuetifyjs.com>
This reverts commit e994942.
…9488) Co-authored-by: John Leider <john@vuetifyjs.com>
fixes vuetifyjs#19005 Co-authored-by: John Leider <john@vuetifyjs.com>
d758ead
to
0759ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an icon is clickable, keyboard navigation to the icon should be allowed. If
onClick
is defined, I am setting thetabindex
to 0resolves vuetifyjs#18482
Markup: